Repository navigation
[material_ui] Migrate M3 Menu template to use new gen_defaults - #13057
Merged
auto-submit[bot] merged 3 commits intoOct 2, 2026
Merged
Conversation
QuncCccccc
added
override: no versioning needed
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the generation of Material 3 menu defaults to the updated token template system. It moves the generated menu defaults out of menu_anchor.dart into a separate generated file menu_defaults_m3.g.dart, updates MenuTemplate to MenuTemplateM3 using typed tokens, enables the menu template generation in gen_defaults.dart, and implements a corresponding unit test in gen_defaults_test.dart. There are no review comments, and I have no feedback to provide.
github-actions
Bot
added
p: material_ui
triage-design
elliette
self-requested a review
September 29, 2026 21:19
elliette
approved these changes
Oct 1, 2026
elliette
left a comment
elliette
left a comment
Member
There was a problem hiding this comment.
Thank you for migrating so many of these!
…gration # Conflicts: # packages/material_ui/tool/gen_defaults/bin/gen_defaults.dart # packages/material_ui/tool/gen_defaults/test/gen_defaults_test.dart
QuncCccccc
added
the
autosubmit
jesswrd
pushed a commit
to jesswrd/flutter
that referenced
this pull request
Oct 2, 2026
…er#193711) flutter/packages@d5ec6db...5620e65 2026-10-02 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 Menu template to use new gen_defaults (flutter/packages#13057) 2026-10-02 44747303+theprantadutta@users.noreply.github.com [material_ui] Repaint NavigationIndicator when the selection changes without pointer input (flutter/packages#13010) 2026-10-01 tarrinneal@gmail.com [tool] Use flutter pub for packages that depend on jni (flutter/packages#13087) 2026-10-01 72785248+fkrhzbllh@users.noreply.github.com [material_ui] Migrate M3 snackbar defaults to new gen_defaults (flutter/packages#13009) 2026-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 6a19cca to 5fc3468 (6 revisions) (flutter/packages#13105) 2026-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from d649d2b to e89fd0a (27 revisions) (flutter/packages#13104) 2026-10-01 70351342+burakJs@users.noreply.github.com [webview_flutter] Add gesture blocking policy to WebKitWebViewWidgetCreationParams (flutter/packages#12496) 2026-10-01 21270878+elliette@users.noreply.github.com [material_ui] Update Material tokens to Material version 38.2.83 (flutter/packages#13082) 2026-10-01 dkwingsmt@users.noreply.github.com [material_ui] Migrate MaterialApp API doc snippets to {@example} and add unit tests (batch 6) (flutter/packages#13021) 2026-10-01 dkwingsmt@users.noreply.github.com [material_ui] Migrate AppBar, SliverAppBar, BottomAppBar, and Scaffold API doc snippets to {@example} (batch 7) (flutter/packages#13023) 2026-10-01 jessiewong401@gmail.com [various] Update Robolectric to 4.17 (flutter/packages#13041) 2026-10-01 tarrinneal@gmail.com [pigeon] pin native interop related dev deps and update some docs (flutter/packages#13103) 2026-10-01 stuartmorgan@google.com [tool] Add more documentation (flutter/packages#13063) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work toward flutter/flutter#187899.
Fixes flutter/flutter#188421.
This PR migrates the M3 Menu defaults template to use the new gen_defaults in material_ui.
The generated defaults remain unchanged.
Pre-Review Checklist
[shared_preferences]///).