Skip to content

[cross_file] Move cross_file into a federated cross_file directory - #12869

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
bparrishMines:move_cross_file
Sep 15, 2026
Merged

auto-submit[bot] merged 3 commits into
flutter:mainfrom
bparrishMines:move_cross_file

Conversation

@bparrishMines

@bparrishMines bparrishMines commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Moves packages/cross_file/ into packages/cross_file/cross_file to prepare for flutter/flutter#91869.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various files in the cross_file package, including source code, tests, and configuration files. No review comments were provided, so there is no feedback to address.

@bparrishMines bparrishMines changed the title move cross_file into a cross_file folder [cross_file] Move cross_file into a federated cross_file directory Sep 14, 2026
@bparrishMines bparrishMines added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 14, 2026
@bparrishMines

Copy link
Copy Markdown
Contributor Author

Changelog and pubspec changes overriden because this just moves the location of the package with no code changes.

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you'll need to update the repository link in the pubspec to make CI happy. It's fine not to publish that; the old link is fine for a while since it's the parent of the correct location, and the app-facing package will publish soon anyway.

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 15, 2026
@auto-submit
auto-submit Bot merged commit cb4f49d into flutter:main Sep 15, 2026
13 checks passed
@bparrishMines
bparrishMines deleted the move_cross_file branch September 15, 2026 16:42
auto-submit Bot pushed a commit that referenced this pull request Sep 15, 2026
…`cross_file` (#12825)

Platform interface of `cross_file`.

This depends on #12869 to land first.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
GhagSagar23 pushed a commit to Kryonex-Labs/flutter that referenced this pull request Sep 16, 2026
…r#192876)

flutter/packages@bebbb57...c2b58e1

2026-09-15 stuartmorgan@google.com [local_auth] Convert implementation
to Kotlin (flutter/packages#12635)
2026-09-15 mhmmd.bayraktar@gmail.com [pigeon] Treat NSNull as null for
non-null Flutter API returns (flutter/packages#12531)
2026-09-15 daniel.leon@cloudsufi.com [espresso] Adopt code-excerpts for
README (flutter/packages#12644)
2026-09-15 daniel.leon@cloudsufi.com [pointer_interceptor] Adopt
code-excerpts for README (flutter/packages#12641)
2026-09-15 47866232+chunhtai@users.noreply.github.com [ci] Checks
unmerged batch release sync back before next release
(flutter/packages#12868)
2026-09-15 puneetkukreja98@gmail.com [material_ui] Add sortIconBuilder
to DataTable, PaginatedDataTable, and DataTableThemeData
(flutter/packages#12645)
2026-09-15 10687576+bparrishMines@users.noreply.github.com
[cross_file_platform_interface] Platform interface implementation of
`cross_file` (flutter/packages#12825)
2026-09-15 10687576+bparrishMines@users.noreply.github.com [cross_file]
Move cross_file into a federated cross_file directory
(flutter/packages#12869)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: cross_file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants