Repository navigation
[material_ui] Add sortIconBuilder to DataTable, PaginatedDataTable, and DataTableThemeData - #12645
Merged
Merged
Conversation
github-actions
Bot
added
p: material_ui
triage-design
Closed
9 of 10 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a sortIconBuilder parameter to DataTable, PaginatedDataTable, and DataTableThemeData to support custom sorting indicators, along with corresponding tests and documentation. Feedback suggests simplifying the theme resolution in DataTable by removing the redundant fallback to themeData.dataTableTheme.sortIconBuilder, as DataTableTheme.of(context) already handles this fallback.
elliette
changed the title
Contributor
Author
|
Hi @Piinks , I’ve addressed the feedback and the PR is ready for your review. Please take a look when you have a chance! |
Piinks
reviewed
Sep 2, 2026
Contributor
|
Thanks for the contribution! Seems you haven’t completed all of the items in the PR checklist above. Please review the checklist, updating the PR as appropriate:) |
puneetkukreja98
force-pushed
the
port-pr-188729
branch
from
September 9, 2026 05:02
92f01fa to
15579ef
Compare
Contributor
Author
|
Hi @Piinks and @QuncCccccc , I’ve addressed the last feedback and the PR is ready for your review. Please take a look when you have a chance! |
puneetkukreja98
added
the
autosubmit
GhagSagar23
pushed a commit
to Kryonex-Labs/flutter
that referenced
this pull request
Sep 16, 2026
…r#192876) flutter/packages@bebbb57...c2b58e1 2026-09-15 stuartmorgan@google.com [local_auth] Convert implementation to Kotlin (flutter/packages#12635) 2026-09-15 mhmmd.bayraktar@gmail.com [pigeon] Treat NSNull as null for non-null Flutter API returns (flutter/packages#12531) 2026-09-15 daniel.leon@cloudsufi.com [espresso] Adopt code-excerpts for README (flutter/packages#12644) 2026-09-15 daniel.leon@cloudsufi.com [pointer_interceptor] Adopt code-excerpts for README (flutter/packages#12641) 2026-09-15 47866232+chunhtai@users.noreply.github.com [ci] Checks unmerged batch release sync back before next release (flutter/packages#12868) 2026-09-15 puneetkukreja98@gmail.com [material_ui] Add sortIconBuilder to DataTable, PaginatedDataTable, and DataTableThemeData (flutter/packages#12645) 2026-09-15 10687576+bparrishMines@users.noreply.github.com [cross_file_platform_interface] Platform interface implementation of `cross_file` (flutter/packages#12825) 2026-09-15 10687576+bparrishMines@users.noreply.github.com [cross_file] Move cross_file into a federated cross_file directory (flutter/packages#12869) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports flutter/flutter#188729 from flutter/flutter to flutter/packages
Fixes: flutter/flutter#91801
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2