[interactive_media_ads] Pin iOS dependency maximum #10349
Conversation
GoogleInteractiveMediaAds [released 3.28.10](googleads/swift-package-manager-google-interactive-media-ads-ios@7f38970) which dropped iOS 13 and 14, breaking our tree. This sets a max version on the dependency to avoid picking up a version that is not compatible with our wrapper's iOS version support. Longer term we can explore expanding the range, but this is non-trivial for Swift Package Manager, so this is the simplest way to fix the tree and clients in the short term.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
platform-android
platform-ios
p: interactive_media_ads
|
test-exempt: (un-)rolling dependencies |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly pins the maximum version for the GoogleInteractiveMediaAds iOS dependency to prevent using a new version that dropped support for iOS 13 and 14. The version numbers and dependency specifications are updated consistently across all relevant files. My feedback includes suggestions to add TODO comments to track this temporary version pin for future maintenance.
stuartmorgan-g
added
the
autosubmit
flutter/packages@1a7075b...3d926aa 2025-11-04 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.1.0 to 5.3.0 in /packages/espresso/android (flutter/packages#10348) 2025-11-04 engine-flutter-autoroll@skia.org Roll Flutter from 6f8abdd to 027f2e4 (26 revisions) (flutter/packages#10335) 2025-11-03 stuartmorgan@google.com [google_sign_in] Remove use of OCMock (flutter/packages#10290) 2025-11-03 stuartmorgan@google.com [interactive_media_ads] Pin iOS dependency maximum (flutter/packages#10349) 2025-10-30 magder@google.com [webview_flutter_wkwebview] Remove specialization of 'map' to fix Swift warning (flutter/packages#9810) 2025-10-30 engine-flutter-autoroll@skia.org Roll Flutter from df72035 to 6f8abdd (16 revisions) (flutter/packages#10327) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
* 'main' of https://github.com/CaoGiaHieu-dev/packages: Update packages/go_router/CHANGELOG.md [tool] Remove use of FETCH_HEAD (flutter#10357) Roll Flutter from 027f2e410241 to e5d5c01850f2 (73 revisions) (flutter#10362) [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter#10337) [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter#9242) [pigeon] Replace containsKey with contains in Kotlin generator (flutter#10274) [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter#10245) [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter#10256) [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter#10328) [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.1.0 to 5.3.0 in /packages/espresso/android (flutter#10348) Roll Flutter from 6f8abdd77820 to 027f2e410241 (26 revisions) (flutter#10335) [google_sign_in] Remove use of OCMock (flutter#10290) [interactive_media_ads] Pin iOS dependency maximum (flutter#10349)
2 participants
GoogleInteractiveMediaAds released 3.28.10 which dropped iOS 13 and 14, breaking our tree. This sets a max version on the dependency to avoid picking up a version that is not compatible with our wrapper's iOS version support.
Longer term we can explore expanding the range, but this is non-trivial for Swift Package Manager, so this is the simplest way to fix the tree and clients in the short term.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3