[pigeon] Replace containsKey with contains in Kotlin generator #10274
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly replaces the deprecated containsKey with contains in the Kotlin generator. However, it also includes extensive formatting changes across numerous files and languages (Dart, C++, Objective-C, etc.), and adds a large number of new generated test files. Mixing a functional fix with large-scale stylistic changes and new files makes the pull request difficult to review. It is highly recommended to separate these different kinds of changes into distinct pull requests to improve reviewability and maintain a clean version history.
stuartmorgan-g
requested changes
Oct 22, 2025
stuartmorgan-g
changed the title
tarrinneal
force-pushed
the
containskey
branch
from
8c40ad6 to
51f8bc5
Compare
github-actions
bot
added
platform-ios
p: interactive_media_ads
tarrinneal
force-pushed
the
containskey
branch
from
51f8bc5 to
4367315
Compare
github-actions
bot
removed
platform-ios
p: interactive_media_ads
tarrinneal
force-pushed
the
containskey
branch
from
4367315 to
2bc9a77
Compare
stuartmorgan-g
approved these changes
Oct 24, 2025
stuartmorgan-g
added
the
autosubmit
CaoGiaHieu-dev
added a commit
to CaoGiaHieu-dev/packages
that referenced
this pull request
Nov 5, 2025
* 'main' of https://github.com/CaoGiaHieu-dev/packages: Update packages/go_router/CHANGELOG.md [tool] Remove use of FETCH_HEAD (flutter#10357) Roll Flutter from 027f2e410241 to e5d5c01850f2 (73 revisions) (flutter#10362) [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter#10337) [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter#9242) [pigeon] Replace containsKey with contains in Kotlin generator (flutter#10274) [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter#10245) [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter#10256) [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter#10328) [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.1.0 to 5.3.0 in /packages/espresso/android (flutter#10348) Roll Flutter from 6f8abdd77820 to 027f2e410241 (26 revisions) (flutter#10335) [google_sign_in] Remove use of OCMock (flutter#10290) [interactive_media_ads] Pin iOS dependency maximum (flutter#10349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#177097