Initialize the lifecycle state with initial state in window. Roll engine (19 commits) #28688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add tests. |
Hixie
added
the
framework
|
flutter/engine#8032 needs to be rolled in with this to make tests happy |
matthew-carroll
approved these changes
Mar 6, 2019
GaryQian
changed the title
|
Could you fix the links in the PR description to point to |
|
Thanks! We should probably create a script that generates a PR description like this for people who manually roll. |
|
Yeah, copy-pasted it from my git command-line and didn't realized it tagged a bunch of irrelevant PRs. |
10 tasks
|
Would you mind updating the PR description again? You can use the new script I added. Otherwise this LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will initialize the app lifecycle state to the initial values passed by the platform and trigger the proper event at app startup.
Dependent on the changes in flutter/engine#7999.
Fix for #2716.
Previously, the value of SchedulerBindings.instance.lifecycleState was null at startup since the messages were dropped before the dart isolate was ready to receive them.
git log --oneline --no-merges f4951df..a48cd16
a48cd16 Update a11y word forward/back enum names (flutter/engine#8073)
b5f59ed Delay the vsync callback till the frame start time specified by embedder. (flutter/engine#8072)
7426305 Mark const extern (flutter/engine#8077)
d3f6d7a only partial rule revert (flutter/engine#8078)
d71bfe5 Only build a full Dart SDK when building for the host system (flutter/engine#8071)
de90dbf Refactor web configuration/ Add dartdevc (flutter/engine#7978)
ff46dd3 Roll src/third_party/skia 4c1ea43a79b5..88b8d1124b72 (8 commits) (flutter/engine#8070)
80c6dd2 Roll src/third_party/skia 692122e3ef23..4c1ea43a79b5 (3 commits) (flutter/engine#8069)
68ed654 Roll src/third_party/skia 3c957d575c58..692122e3ef23 (6 commits) (flutter/engine#8067)
ca0bac4 Revert "add signal to pointer kinds" (flutter/engine#8066)
3fb627f add signal to pointer kinds (flutter/engine#8065)
5a06afa Roll src/third_party/skia 801a9c16d81e..3c957d575c58 (19 commits) (flutter/engine#8063)
a93d99d A11y callback (flutter/engine#8005)
3661d5e Re-land "Buffer lifecycle in WindowData" (flutter/engine#8032)
471a2c8 Send scroll events from the macOS shell (flutter/engine#8056)
2fe9c9b Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (flutter/engine#8060)
3335764 Skip skp files in license check (flutter/engine#8050)
7f16789 Remove redundant thread checker in FML. (flutter/engine#8053)
840c523 Correct URL for Cirrus CI build status badge (flutter/engine#8054)
57c120a remove extra source files (flutter/engine#8052)
4773375 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (flutter/engine#8051)
70a18b5 Add clang static analysis support to gn wrapper (flutter/engine#8047)
b30f989 Improve elevation bounds for physical shape layers (flutter/engine#8044)
e37bd27 Fix weak pointer use violations in shell and platform view. (flutter/engine#8046)
dd80fc9 Add engine support for scrollwheel events (flutter/engine#7494)