This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Re-land "Buffer lifecycle in WindowData"" #8025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shell/common/engine.cc
Outdated
| @@ -291,6 +291,8 @@ bool Engine::HandleLifecyclePlatformMessage(blink::PlatformMessage* message) { | |||
| if (state == "AppLifecycleState.resumed" && have_surface_) { | |||
| ScheduleFrame(); | |||
| } | |||
| runtime_controller_->SetLifecycleState(state); | |||
| // We always want pass the message forwards directly into the framework. | |||
There was a problem hiding this comment.
Would like to clarify this comment. How about something like Always forward these messages to the framework?
chinmaygarde
approved these changes
Mar 5, 2019
|
Abandoned in favor of #8032 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #8010
Will require some framework-side testing updates (TestWindow class) flutter/flutter#28688 to support this.