Fix MaterialBannerTheme.data nullablity #180008
Closed
+100
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly makes MaterialBannerTheme.data non-nullable, aligning it with other theme data patterns in the framework. The accompanying tests are well-written and cover the new functionality of using a local MaterialBannerTheme. I've added one comment regarding code duplication in the new tests, which could be refactored for better maintainability.
QuncCccccc
reviewed
Dec 17, 2025
Contributor
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
I don't think we need to remove the nullable type if it already exists because this may cause breakages.
Contributor
Author
|
As you want, the motivation were:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
MaterialBannerTheme.datanon nullable similarly to the data field of other themes.(See #179736 (comment) for context).
Tests
Adds 2 tests.
Those tests were missing tests for
MaterialBannerTheme.