Add FloatingActionButtonTheme #179736
Add FloatingActionButtonTheme #179736
Conversation
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces FloatingActionButtonTheme, an InheritedTheme that allows for theming FloatingActionButton widgets within a subtree. This is a standard pattern in Flutter and brings FloatingActionButton in line with other Material components that have their own theme widgets. The implementation correctly uses dependOnInheritedWidgetOfExactType and falls back to Theme.of(context).floatingActionButtonTheme. The documentation for FloatingActionButton and FloatingActionButtonThemeData has been updated to reflect this change. Two new tests have been added to verify the behavior of the new theme, ensuring that it overrides the app-level theme and that widget-level properties take precedence. The changes are well-implemented and follow existing conventions in the Flutter framework.
packages/flutter/test/material/floating_action_button_theme_test.dart
Outdated
Show resolved
Hide resolved
bleroux
force-pushed
the
Add_FloatingActioButtonTheme
branch
from
6541307 to
d5be232
Compare
| const FloatingActionButtonTheme({super.key, this.data, required super.child}); | ||
|
|
||
| /// The properties for descendant [FloatingActionButton] widgets. | ||
| final FloatingActionButtonThemeData? data; |
There was a problem hiding this comment.
Are there any cases that data might be null? I'm thinking maybe we can just make the type be FloatingActionButtonThemeData.
There was a problem hiding this comment.
Oh very good catch!
I used MaterialBannerTheme as an inspiration when writing this PR and I just realized that it is the only theme where data is nullable. Probably by mistake.
|
|
||
| await tester.pumpWidget( | ||
| MaterialApp( | ||
| theme: ThemeData().copyWith( |
There was a problem hiding this comment.
nit:
| theme: ThemeData().copyWith( | |
| theme: ThemeData( |
bleroux
force-pushed
the
Add_FloatingActioButtonTheme
branch
2 times, most recently
from
91f3124 to
c3b7c9b
Compare
bleroux
force-pushed
the
Add_FloatingActioButtonTheme
branch
from
c3b7c9b to
2b321e0
Compare
bleroux
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
2 participants
Description
This PR adds the
FloatingActionButtonThemesubclass of InheritedTheme. Similarly to other theme classes.This missing theme class was mentioned in flutter.dev/go/material-theme-system-updates:
"FloatingActionButtonThemeData is conformant but there’s no FloatingActionButtonTheme class. "
Related Issue
Fixes Missing FloatingActionButtonTheme
Tests
Adds 2 tests.