Revert "Check GTK calls are done on the same thread."

[flar]

Reverts #174488

It is causing failures in testing:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8705343407724739553/+/u/build_ci_host_release_benchmarks_flutter_build_dart:copy_dart_sdk_flutter_display_list:display_list_benchmarks_flutter_display_list:display_list_builder_benchmarks_flutter_display_list:display_list_region_benchmarks_flutter_display_list:display_list_transform_benchmarks_flutter_fml:fml_benchmarks_flutter_impeller_geometry:geometry_benchmarks_flutter_lib_ui:ui_benchmarks_flutter_shell_common:shell_benchmarks_flutter_shell_testing_flutter_txt:txt_benchmarks_flutter_tools_path_ops_flutter_build_archives:flutter_patched_sdk_flutter:unittests/stdout

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[gemini-code-assist]

Code Review

This pull request reverts a previous change that introduced thread checking for GTK calls in the mock GTK implementation. The original change was causing test failures, and this revert addresses that by removing the thread checking logic. The changes include the removal of the check_thread function, all its invocations, and the associated GThread* member from the MockGtk class. Additionally, several mock function implementations that were added for the purpose of thread checking have been removed. The revert appears to be correct and complete.

[robert-ancell]

Merge caused a duplicate function to be defined in the mocks.

[flar]

Merge caused a duplicate function to be defined in the mocks.

Yeah, it doesn't appear in the PR, but it is in the repo now.

[flar]

Blame says that the other copy at line ~170 comes from another PR you submitted 17 hours ago. Was there a race condition on the merge queue? Or perhaps your PR diff was computed against a repo that didn't have the other change in it yet?

[robert-ancell]

This change added this mock function, the second PR also added the same mock function and was landed before this change. The PR for this change showed no merge conflict and had already passed the tests, so showed no issue when submitting to the merge queue.

In hindsight I should have merged this PR with main first and then the CI checks would have caught this.

[flutter-dashboard]

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

[fluttergithubbot]

An existing Git SHA, ea24f00e95a984edbbe421ad2a4bf7b2d6d7b0c7, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

[matanlurey]

My bad pressed the wrong button.

It's in the queue to merge now.

[robert-ancell]

Has the queue stalled?