Skip to content

Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky #174112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky #174112

merged 1 commit into from
Aug 28, 2025

Conversation

fluttergithubbot
Copy link
Contributor

Issue link: #174111

@fluttergithubbot fluttergithubbot added the team-engine Owned by Engine team label Aug 20, 2025
@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Aug 20, 2025
@github-actions github-actions bot removed c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team labels Aug 20, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly marks the Linux_pixel_7pro drive_perf_debug_warning test as flaky by setting bringup: true. My review includes one suggestion to align the comment with the project's documented conventions for marking flaky tests, which will improve maintainability.

.ci.yaml
task_name: devtools_profile_start_test

- name: Linux_pixel_7pro drive_perf_debug_warning
bringup: true # Flaky https://github.com/flutter/flutter/issues/174111
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the project's conventions for marking flaky tests, please format the comment as # TODO(username): github issue url and place it on the line above bringup: true. This convention is documented in the docs/infra/Reducing-Test-Flakiness.md file (line 34).

    # TODO(<github_username>): https://github.com/flutter/flutter/issues/174111
    bringup: true

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Aug 28, 2025
Merged via the queue into flutter:master with commit a16a112 Aug 28, 2025
159 of 160 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
f3a72a6 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
83f3104 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
a27df01 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
2029fc7 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
6a7c5e0 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
c2d6b6c 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
c44fdaa 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
c71e1ce 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
1b45d93 
…flutter/flutter#174112)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
50542dc 
…flutter/flutter#174112)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
38e6814 
…flutter/flutter#174112)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
9741258 
…flutter/flutter#174112)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
df5f862 
…flutter/flutter#174112)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
e6db3fb 
…flutter/flutter#174112)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
773f924 
…flutter/flutter#174112)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
337c4ad 
…flutter/flutter#174112)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025
@engine-flutter-autoroll
a16a11272 Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (…
6f14d98 
…flutter/flutter#174112)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 2, 2025
@engine-flutter-autoroll
Roll Flutter from da5523afc3c1 to 6b18740d5a23 (49 revisions) (#9926)
636102c 
Roll Flutter from da5523afc3c1 to 6b18740d5a23 (49 revisions)

flutter/flutter@da5523a...6b18740

2025-08-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 11f6cd99f6b3 to 72cda0f3dc42 (2 revisions) (flutter/flutter#174697)
2025-08-29 sokolovskyi.konstantin@gmail.com Fix empty adaptive text selection toolbars building. (flutter/flutter#174656)
2025-08-29 jhy03261997@gmail.com [flutter_test] update the _isImportantForAccessibility method in SemanticsController to include tooltip (flutter/flutter#174476)
2025-08-29 engine-flutter-autoroll@skia.org Roll Skia from 89794f0b5384 to 43e79dc80ca8 (1 revision) (flutter/flutter#174678)
2025-08-29 engine-flutter-autoroll@skia.org Roll Skia from f3c8b4c677f5 to 89794f0b5384 (6 revisions) (flutter/flutter#174675)
2025-08-29 47866232+chunhtai@users.noreply.github.com Implement Overlay.of with inherited widget (flutter/flutter#174315)
2025-08-29 jacksongardner@google.com [impeller] Support partitioned host buffer (flutter/flutter#174463)
2025-08-29 47866232+chunhtai@users.noreply.github.com Adds semantics for disabled buttons in date picker (flutter/flutter#174064)
2025-08-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bHYRvLv2Dg56RWZF2... to 00VSr-5B7hq0G2eZx... (flutter/flutter#174667)
2025-08-29 robert.ancell@canonical.com Check GTK calls are done on the same thread. (#174488) (flutter/flutter#174624)
2025-08-29 bkonyi@google.com [ Tool ] Only listen for DebugConnectionInfo if the service protocol is supported (flutter/flutter#174664)
2025-08-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 89023922f96d to 11f6cd99f6b3 (9 revisions) (flutter/flutter#174669)
2025-08-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] Refactor renderers to use the same frontend code (#174588)" (flutter/flutter#174672)
2025-08-28 jhy03261997@gmail.com [a11y] [test] containsSemantics  can ignore SemanticsValidationResult (flutter/flutter#174608)
2025-08-28 sokolovskyi.konstantin@gmail.com Fix some issues in engine-tool README. (flutter/flutter#174512)
2025-08-28 fluttergithubbot@gmail.com Marks Linux_pixel_7pro new_gallery__transition_perf to be flaky (flutter/flutter#174106)
2025-08-28 ahmedsameha1@gmail.com Make sure that an AlertDialog doesn't crash in 0x0 environment (flutter/flutter#174091)
2025-08-28 fluttergithubbot@gmail.com Marks Linux_pixel_7pro hello_world_impeller to be flaky (flutter/flutter#173699)
2025-08-28 fluttergithubbot@gmail.com Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (flutter/flutter#174112)
2025-08-28 fluttergithubbot@gmail.com Marks Linux_android_emu android_display_cutout to be flaky (flutter/flutter#174501)
2025-08-28 fluttergithubbot@gmail.com Marks Linux_pixel_7pro service_extensions_test to be flaky (flutter/flutter#174114)
2025-08-28 fluttergithubbot@gmail.com Marks Windows plugin_test to be flaky (flutter/flutter#174117)
2025-08-28 fluttergithubbot@gmail.com Marks Windows_mokey basic_material_app_win__compile to be flaky (flutter/flutter#173702)
2025-08-28 fluttergithubbot@gmail.com Marks Mac_mokey microbenchmarks to be flaky (flutter/flutter#174102)
2025-08-28 fluttergithubbot@gmail.com Marks Linux_mokey complex_layout__start_up to be flaky (flutter/flutter#173692)
2025-08-28 fluttergithubbot@gmail.com Marks Linux build_android_host_app_with_module_aar to be flaky (flutter/flutter#172631)
2025-08-28 fluttergithubbot@gmail.com Marks Linux_pixel_7pro new_gallery_opengles_impeller__transition_perf to be flaky (flutter/flutter#173338)
2025-08-28 fluttergithubbot@gmail.com Marks Linux_pixel_7pro platform_views_scroll_perf_impeller__timeline_summary to be flaky (flutter/flutter#172211)
2025-08-28 jason-simmons@users.noreply.github.com Remove the option to disable the merged platform/UI thread on Android and iOS (flutter/flutter#174408)
2025-08-28 mdebbar@google.com Don't fail when hot restarting `web-server` and there are no connected clients (flutter/flutter#174600)
2025-08-28 engine-flutter-autoroll@skia.org Roll Skia from 7c2fe2629d4a to f3c8b4c677f5 (7 revisions) (flutter/flutter#174654)
2025-08-28 mdebbar@google.com [WebParagraph] More plumbing towards making it usable in Flutter apps (flutter/flutter#174587)
2025-08-28 engine-flutter-autoroll@skia.org Roll Packages from 86fbeec to 141d8e3 (6 revisions) (flutter/flutter#174645)
2025-08-28 1961493+harryterkelsen@users.noreply.github.com [web] Refactor renderers to use the same frontend code (flutter/flutter#174588)
2025-08-28 engine-flutter-autoroll@skia.org Roll Skia from eb000b138a9d to 7c2fe2629d4a (3 revisions) (flutter/flutter#174637)
2025-08-28 bkonyi@google.com [ Tool ] Roll package:dwds 25.0.4 (flutter/flutter#174601)
2025-08-28 engine-flutter-autoroll@skia.org Roll Skia from 9b1642f2cfea to eb000b138a9d (2 revisions) (flutter/flutter#174627)
2025-08-28 engine-flutter-autoroll@skia.org Roll Skia from 430d60054d66 to 9b1642f2cfea (7 revisions) (flutter/flutter#174625)
2025-08-28 30870216+gaaclarke@users.noreply.github.com Refactored Canvas to disallow null inline contexts. (flutter/flutter#174530)
2025-08-28 flar@google.com Revert "Check GTK calls are done on the same thread." (flutter/flutter#174604)
2025-08-27 engine-flutter-autoroll@skia.org Roll Skia from 2a12b57fbbf0 to 430d60054d66 (3 revisions) (flutter/flutter#174590)
2025-08-27 ttankkeo112@gmail.com Retry "Implements the Android native stretch effect as a fragment shader (Impeller-only)." (flutter/flutter#173885)
2025-08-27 matanlurey@users.noreply.github.com Use raw `--removal-label "cp: ..."` when removing labels for unmerged PRs (flutter/flutter#174596)
2025-08-27 jakemac@google.com Flutter driver deserialization (flutter/flutter#172927)
2025-08-27 robert.ancell@canonical.com Check GTK calls are done on the same thread. (flutter/flutter#174488)
2025-08-27 matanlurey@users.noreply.github.com Fix broken reference to `PULL_REQUEST_CP_TEMPLATE.md` after refactor (flutter/flutter#174595)
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@fluttergithubbot @mboetger
Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (flutter#…
a960c05 
…174112)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro drive_perf_debug_warning"
}
-->
Issue link: flutter#174111
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
@fluttergithubbot @korca0220
Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (flutter#…
99ee949 
…174112)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro drive_perf_debug_warning"
}
-->
Issue link: flutter#174111
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
@fluttergithubbot @Jaineel-Mamtora
Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky (flutter#…
5a28f53 
…174112)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro drive_perf_debug_warning"
}
-->
Issue link: flutter#174111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole Awaiting requested review from jtmcdole

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: flake Tests that sometimes, but not always, incorrectly pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fluttergithubbot @matanlurey