try lint avoid_unused_constructor_parameters #13250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Nov 29, 2017
| String name, | ||
| @required this.value, | ||
| @required DiagnosticsTreeStyle style, | ||
| String emptyBodyDescription, |
Contributor
There was a problem hiding this comment.
nice! the lint caught some dead code left over after refactoring.
Hixie
reviewed
Nov 29, 2017
| _showCursor = showCursor ?? new ValueNotifier<bool>(false), | ||
| _hasFocus = hasFocus ?? false, | ||
| _maxLines = maxLines, | ||
| _selectionColor = selectionColor, |
Contributor
|
|
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.