Skip to content

Commit 5d6c681

Browse files
authored
try lint avoid_unused_constructor_parameters (flutter#13250)
1 parent a4e849e commit 5d6c681

File tree

4 files changed

+3
-3
lines changed

4 files changed

+3
-3
lines changed

analysis_options.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ linter:
7070
# - avoid_setters_without_getters # not yet tested
7171
- avoid_slow_async_io
7272
# - avoid_types_on_closure_parameters # conflicts with always_specify_types
73-
# - avoid_unused_constructor_parameters # not yet tested
73+
# - avoid_unused_constructor_parameters # https://github.com/dart-lang/linter/pull/847
7474
- await_only_futures
7575
- camel_case_types
7676
- cancel_subscriptions

analysis_options_repo.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ linter:
6363
# - avoid_setters_without_getters # not yet tested
6464
- avoid_slow_async_io
6565
# - avoid_types_on_closure_parameters # conflicts with always_specify_types
66-
# - avoid_unused_constructor_parameters # not yet tested
66+
# - avoid_unused_constructor_parameters # https://github.com/dart-lang/linter/pull/847
6767
- await_only_futures
6868
- camel_case_types
6969
- cancel_subscriptions

packages/flutter/lib/src/foundation/diagnostics.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1955,7 +1955,6 @@ class DiagnosticableNode<T extends Diagnosticable> extends DiagnosticsNode {
19551955
String name,
19561956
@required this.value,
19571957
@required DiagnosticsTreeStyle style,
1958-
String emptyBodyDescription,
19591958
}) : assert(value != null),
19601959
super(
19611960
name: name,

packages/flutter/lib/src/rendering/editable.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ class RenderEditable extends RenderBox {
127127
_showCursor = showCursor ?? new ValueNotifier<bool>(false),
128128
_hasFocus = hasFocus ?? false,
129129
_maxLines = maxLines,
130+
_selectionColor = selectionColor,
130131
_selection = selection,
131132
_offset = offset {
132133
assert(_showCursor != null);

0 commit comments

Comments
 (0)