Meta-issue: Update all code to use optional new/const #18604

Activity

1. a14n commented on Jun 19, 2018

   

   a14n

   on Jun 19, 2018

   Contributor

   More actions

   Actually it's still blocked by dart-lang/sdk#57706 and dart-lang/sdk#57712
2. mit-mit commented on Jun 20, 2018

   

   mit-mit

   on Jun 20, 2018

   MemberAuthor

   More actions

   Thanks, I reactivated dart-lang/sdk#32596
3. pq commented on Jun 26, 2018

   

   pq

   on Jun 26, 2018

   Contributor

   More actions

   @a14n : once the new linter makes it's way into a vended SDK will we be good to make these changes?
4. a14n commented on Jun 27, 2018

   

   a14n

   on Jun 27, 2018

   Contributor

   More actions

   I tried to remove unnecessary new/const from flutter codebase and faced a new issue in analyzer dart-lang/sdk#33647
5. a14n commented on Jul 16, 2018

   

   a14n

   on Jul 16, 2018

   Contributor

   More actions

   Optional const landed in #19342

   🎉React with 🎉1Reacted by Phil Quitslund
6. pq commented on Jul 16, 2018

   

   pq

   on Jul 16, 2018

   Contributor

   More actions

   @a14n: this is fantastic. Remind me the plan for unnecessary_new?
7. mit-mit commented on Aug 6, 2018

   

   mit-mit

   on Aug 6, 2018

   MemberAuthor

   More actions

   @a14n do we have the no new lint?
8. a14n commented on Aug 6, 2018

   

   a14n

   on Aug 6, 2018

   Contributor

   More actions

   unnecessary_const landed with #20103 and flutter-team-archive/plugins#682.
   unnecessary_new is waiting for reviews with #20138 and flutter-team-archive/plugins#701.

   🎉React with 🎉1Reacted by Michael Thomsen
9. zoechi

   added

   c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.

   on Aug 24, 2018
10. a14n commented on Oct 5, 2018

    

    a14n

    on Oct 5, 2018

    Contributor

    More actions

    unnecessary new/const have been removed from flutter/flutter, flutter/plugins and soon in flutter/packages.
    On flutter.io the only remaining place with new/const seems to be in images like on home page at the Fast development section.

    🎉React with 🎉1Reacted by Michael Thomsen
11. mit-mit commented on Oct 8, 2018

    

    mit-mit

    on Oct 8, 2018

    MemberAuthor

    More actions

    Excellent! I'll make sure with @maguinis that we get all images updated!
12. mit-mit commented on Oct 15, 2018

    

    mit-mit

    on Oct 15, 2018

    Last edited by mit-mit

    MemberAuthor

    More actions

    Marking flutter/packages done as flutter/packages#4 was merged
13. mit-mit commented on Oct 15, 2018

    

    mit-mit

    on Oct 15, 2018

    MemberAuthor

    More actions

    Assigning to self as only item left is updating images on flutter.io
14. mit-mit

    self-assigned this

    on Oct 15, 2018
15. a14n commented on Oct 15, 2018

    

    a14n

    on Oct 15, 2018

    Contributor

    More actions

    Actually there's still flutter-team-archive/plugins#818
16. mit-mit commented on Nov 14, 2018

    

    mit-mit

    on Nov 14, 2018

    MemberAuthor

    More actions

    This should be done now

    🎉React with 🎉1Reacted by Alexandre Ardhuin
17. mit-mit

    closed this as completedon Nov 14, 2018
18. github-actions commented on Sep 1, 2021

    

    github-actionsbot

    on Sep 1, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
19. github-actions

    locked as resolved and limited conversation to collaborators on Sep 1, 2021