Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

enable lint unnecessary_const - #682

Merged
goderbauer merged 1 commit into
flutter-team-archive:masterfrom
a14n:unnecessary_const
Aug 1, 2018
Merged

goderbauer merged 1 commit into
flutter-team-archive:masterfrom
a14n:unnecessary_const

Conversation

@a14n

@a14n a14n commented Jul 23, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a14n Can You resolve the merge conflict?

@a14n
a14n force-pushed the unnecessary_const branch from ad994ee to 59dd47b Compare July 30, 2018 19:42
@a14n

a14n commented Jul 30, 2018

Copy link
Copy Markdown
Contributor Author

Updated

I don't understand why some CI tasks fail.

@goderbauer

Copy link
Copy Markdown
Contributor

I've restarted those CI tasks.

@a14n

a14n commented Jul 31, 2018

Copy link
Copy Markdown
Contributor Author

@tvolkert no problem with Fuchsia to merge this PR? (Re. flutter/flutter#19592 (comment))

@tvolkert

Copy link
Copy Markdown
Contributor

Let's hold off on merging just yet -- I'm still wrestling with rolling Flutter into Fuchsia. Thanks!

@tvolkert

tvolkert commented Aug 1, 2018

Copy link
Copy Markdown
Contributor

Ok, this is good to go with respect to Fuchsia! thanks 😄

@goderbauer
goderbauer merged commit 6683c7a into flutter-team-archive:master Aug 1, 2018
@a14n
a14n deleted the unnecessary_const branch August 1, 2018 07:29
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants