-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: b9e86a565f92
head repository: flutter/flutter
compare: eb6af3d029b7
- 13 commits
- 45 files changed
- 15 contributors
Commits on Jan 19, 2025
-
Update documentation on what display information is provided. (#161785)
This was fixed in Linux in #161359
Configuration menu - View commit details
-
Copy full SHA for 6311057 - Browse repository at this point
Copy the full SHA 6311057View commit details
Commits on Jan 20, 2025
-
[ flutter_tool ] Fix flakiness in doctor_test.dart (#161917)
This test was merging two ZeroExecutionTimeValidationResults into a new ValidationResult with an actual execution duration set rather than Duration.zero. Fixes #161918
Configuration menu - View commit details
-
Copy full SHA for 3bfc25f - Browse repository at this point
Copy the full SHA 3bfc25fView commit details -
Roll Packages from f73cb00 to e8f1f63 (9 revisions) (#161914)
flutter/packages@f73cb00...e8f1f63 2025-01-20 mchudy@users.noreply.github.com [in_app_purchase] Update Play Billing library to 7.1.1 (flutter/packages#8218) 2025-01-20 engine-flutter-autoroll@skia.org Roll Flutter from 5517cc9 to b9e86a5 (22 revisions) (flutter/packages#8458) 2025-01-18 stuartmorgan@google.com [pigeon] Update analyzer and formatter (flutter/packages#8456) 2025-01-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 3 directories with 1 update (flutter/packages#8328) 2025-01-17 magder@google.com [local_auth_darwin] Handle when FaceID hardware is available but permissions have been denied for the app (flutter/packages#8348) 2025-01-16 engine-flutter-autoroll@skia.org Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter/packages#8441) 2025-01-15 louisehsu@google.com [in_app_purchase_storekit] expose `jsonRepresentation` for Transactions (flutter/packages#8430) 2025-01-15 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 17025dd to 68415ad (4 revisions) (flutter/packages#8434) 2025-01-15 30872003+misos1@users.noreply.github.com [video_player_avfoundation] fix playback speed resetting (flutter/packages#7657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 27f3f9a - Browse repository at this point
Copy the full SHA 27f3f9aView commit details -
[native assets] Cleanup dead code (#161913)
This PR deletes dead code. Testing: No new use cases covered, all existing use cases covered by existing tests. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 883ef85 - Browse repository at this point
Copy the full SHA 883ef85View commit details
Commits on Jan 21, 2025
-
Make
PipelineOwnerabaseclass (#161789)Such that nobody `implements` it. Currently it has private APIs used by the `RenderObject` class (e.g., the dirty lists). If someone were to implement a `PipelineOwner` outside of object.dart, they will get a runtime `noSuchMethod` crash since they won't be able to provide those private APIs and RenderObjects actually expect those APIs to exist. Will be slow to update/respond due to extremely spotty internet :( ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 4115a78 - Browse repository at this point
Copy the full SHA 4115a78View commit details -
This PR was generated by `flutter update-packages --force-upgrade`.
Configuration menu - View commit details
-
Copy full SHA for 3aa979f - Browse repository at this point
Copy the full SHA 3aa979fView commit details -
Update
ListTiletest to prevent log dump and test error message. (#……161811) Fixes [`ListTile` widget tests dump logs in Flutter CI](#161810) ### Before <img width="1341" alt="Screenshot 2025-01-17 at 17 37 30" src="https://github.com/user-attachments/assets/fa3a6b46-07ae-4f41-9f8c-821943acdd4c" /> ### After <img width="1341" alt="Screenshot 2025-01-17 at 17 36 50" src="https://github.com/user-attachments/assets/6ffd2d19-fa61-4dc5-b5e7-bb0fc8c07008" /> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for d0e0317 - Browse repository at this point
Copy the full SHA d0e0317View commit details -
[native assets] Cleanup dead code 2 (#161916)
This PR deletes dead code. The `FlutterNativeAssetsBuildRunnerImpl` has a `PackageConfig` argument, so the package config file must exist. This means the `hasPackageConfig` method is meaningless, it will always return `true`. The only case where it might have returned false was in the unit test mock. This unit test is now deleted. (It must be the case that `flutter_tools` internally ensures `pub get` has been run in the project before it reaches any code paths that try to build native assets.) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for da080e6 - Browse repository at this point
Copy the full SHA da080e6View commit details -
Fix DropdownMenu icon and item icon misalignment (#161717)
## Description This PR ensures that DropdownMenu icon and items icon are horizontally aligned. Before: The item icon is not aligned with the DropdownMenu leading icon:  After: The item icon is aligned with the DropdownMenu leading icon:  ## Related Issue Fixes [DropdownMenu item icon and DropdownMenu.leadingIcon are not aligned horizontally](#161668) ## Tests Adds 2 tests.
Configuration menu - View commit details
-
Copy full SHA for 539727f - Browse repository at this point
Copy the full SHA 539727fView commit details -
Don't crash flutter tool if Chrome is not available (#154941)
Instead of unawaiting the future, let's ignore it. Fixes issue #154940 I am not sure if tests would be required for this change or not. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Ben Konyi <bkonyi@google.com>
Configuration menu - View commit details
-
Copy full SHA for cc44dba - Browse repository at this point
Copy the full SHA cc44dbaView commit details -
Marks Mac_mokey run_debug_test_android to be flaky (#161656)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_mokey run_debug_test_android" } --> Issue link: #161655Configuration menu - View commit details
-
Copy full SHA for 195e6ff - Browse repository at this point
Copy the full SHA 195e6ffView commit details -
Mark Linux_pixel_7pro flavors_test unflaky (#160994)
This should have been marked unflaky when #156955 was closed. Co-authored-by: Reid Baker <reidbaker@google.com>
Configuration menu - View commit details
-
Copy full SHA for cfb8522 - Browse repository at this point
Copy the full SHA cfb8522View commit details -
Get
etworking for local web engine builds. (#161825)This PR makes a few different changes to make building the web engine via `et` a bit smoother: * Adds a few build steps to `local_engine.json` so that et can build `wasm_release` and `wasm_debug_unopt` builds on Linux and Mac locally. * Removed the part of our `generate_builder_json` step which generates the `linux_web_engine_build.json` file. This previously used to be generated based off of the contents of `felt_config.yaml` but now it's just not parameterized at all, so there is no benefit to generating it and we can just manually maintain the file now. * Fixed an issue where the skwasm debug build was failing due to a wrong output file being specified in the gn rule.
Configuration menu - View commit details
-
Copy full SHA for eb6af3d - Browse repository at this point
Copy the full SHA eb6af3dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff b9e86a565f92...eb6af3d029b7