-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[in_app_purchase] Update Play Billing library to 7.1.1 #8218
base: main
Are you sure you want to change the base?
[in_app_purchase] Update Play Billing library to 7.1.1 #8218
Conversation
@reidbaker Ping on this review |
@gmackall I am not going to get to this. Deferring to you for review. |
The billingClient version upgrade process must proceed as quickly as possible. Currently, in_app_purchase 3.2.0 is using billingClient 6.2.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, added a couple comments. Sorry for the delay on review
...ase_android/android/src/main/java/io/flutter/plugins/inapppurchase/BillingClientFactory.java
Outdated
Show resolved
Hide resolved
...oid/android/src/test/java/io/flutter/plugins/inapppurchase/BillingClientFactoryImplTest.java
Outdated
Show resolved
Hide resolved
...n_app_purchase/in_app_purchase_android/lib/src/billing_client_wrappers/purchase_wrapper.dart
Show resolved
Hide resolved
...app_purchase_android/lib/src/billing_client_wrappers/subscription_offer_details_wrapper.dart
Show resolved
Hide resolved
e7f8b52
to
a061100
Compare
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>
…ove translation logic according to conventions
c0f71e6
to
2ed01f3
Compare
2ed01f3
to
4e5e3ca
Compare
CI is complaining about versioning, but I believe we should first publish the new version of in_app_purchase_android and only once that lands on pub update the dependency in the base package? Or can this be handled inside a single PR? |
See https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins for the process of landing a multi-package PR with interdependencies. |
* **BREAKING CHANGES**: | ||
* Removes the deprecated `ProrationMode` enum. `ReplacementMode` should be used instead. | ||
* Removes the deprecated `BillingClientWrapper.enablePendingPurchases` method. | ||
* Bumps `minSdk` to 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change for in_app_purchase
when rolling the dependency there; we strongly prefer not dropping OS support before the SDK itself.
In this case, Flutter 3.24+ only supports Android SDK 21+, so the way to make this change would be to update the plugin's min SDK version to 3.24, which makes this no longer a breaking change.
Updates Play Billing Library to the latest version 7.1.1. Exposes new APIs as per release notes:
ProductDetails.InstallmentPlanDetails
PendingPurchasesParams
and removes the deprecatedenablePendingPurchases
method onBillingClientWrapper
(breaking change)Purchase.PendingPurchaseUpdate
ProrationMode
as it has been removed from the native library (breaking change)This PR introduces breaking changes in
in_app_purchase_android
, but does not introduce any breaking changes on the platform interface level.Fixes flutter/flutter#147394
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.