[in_app_purchase] Update Play Billing library to 7.1.1 #8218

mchudy · 2024-12-03T22:26:22Z

Updates Play Billing Library to the latest version 7.1.1. Exposes new APIs as per release notes:

Adds Dart representation of ProductDetails.InstallmentPlanDetails
Adds Dart representation of PendingPurchasesParams and removes the deprecated enablePendingPurchases method on BillingClientWrapper (breaking change)
Adds Dart representation of Purchase.PendingPurchaseUpdate
Removes the deprecated ProrationMode as it has been removed from the native library (breaking change)

This PR introduces breaking changes in in_app_purchase_android, but does not introduce any breaking changes on the platform interface level.

Fixes flutter/flutter#147394

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g · 2024-12-17T20:43:08Z

@reidbaker Ping on this review

reidbaker · 2024-12-18T19:37:04Z

@gmackall I am not going to get to this. Deferring to you for review.

wph144 · 2025-01-06T16:42:45Z

The billingClient version upgrade process must proceed as quickly as possible.
Older versions of billingClient cause a low probability of missing payments after a certain period of time.
This may result in cases where the consumer makes a payment but does not receive the service for that payment, so the billingClient version upgrade must be done quickly.

Currently, in_app_purchase 3.2.0 is using billingClient 6.2.0,
and billingClient 7.0.0 version was distributed in May 2024,
so it has now taken more than 7 months.
I hope this gets merged quickly.

gmackall

Mostly LGTM, added a couple comments. Sorry for the delay on review

packages/in_app_purchase/in_app_purchase/CHANGELOG.md

packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md

...ase_android/android/src/main/java/io/flutter/plugins/inapppurchase/BillingClientFactory.java

...oid/android/src/test/java/io/flutter/plugins/inapppurchase/BillingClientFactoryImplTest.java

...n_app_purchase/in_app_purchase_android/lib/src/billing_client_wrappers/purchase_wrapper.dart

...app_purchase_android/lib/src/billing_client_wrappers/subscription_offer_details_wrapper.dart

mchudy · 2025-01-08T23:46:23Z

CI is complaining about versioning, but I believe we should first publish the new version of in_app_purchase_android and only once that lands on pub update the dependency in the base package? Or can this be handled inside a single PR?

stuartmorgan-g · 2025-01-09T13:06:40Z

CI is complaining about versioning, but I believe we should first publish the new version of in_app_purchase_android and only once that lands on pub update the dependency in the base package? Or can this be handled inside a single PR?

See https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins for the process of landing a multi-package PR with interdependencies.

stuartmorgan-g · 2025-01-09T13:11:50Z

packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md

+* **BREAKING CHANGES**:
+  * Removes the deprecated `ProrationMode` enum. `ReplacementMode` should be used instead.
+  * Removes the deprecated `BillingClientWrapper.enablePendingPurchases` method.
+  * Bumps `minSdk` to 21.


This would be a breaking change for in_app_purchase when rolling the dependency there; we strongly prefer not dropping OS support before the SDK itself.

In this case, Flutter 3.24+ only supports Android SDK 21+, so the way to make this change would be to update the plugin's min SDK version to 3.24, which makes this no longer a breaking change.

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

reidbaker

Hold on merging for @stuartmorgan's approval. Specifically if all of the json removal work he wants removed has been done.

reidbaker · 2025-01-17T15:27:29Z

packages/in_app_purchase/in_app_purchase/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## NEXT


I think this is worthy of a version bump.

reidbaker · 2025-01-17T15:29:45Z

..._app_purchase_android/android/src/main/java/io/flutter/plugins/inapppurchase/Translator.java

        .setDebugMessage(billingResult.getDebugMessage())
        .build();
  }

+  static @NonNull PlatformBillingResponse fromBillingResponseCode(int billingResponseCode) {


stuartmorgan-g

Awesome, thanks for all of this cleanup!

It looks like bulid.yaml can be removed, as well as the json_annotation and json_serializable dependencies in pubspec.yaml, but that's all I see that's left.

stuartmorgan-g

Hold on merging for @stuartmorgan's approval.

This PR can't actually be landed as-is; it's saying that it bumps the in_app_purchase_android version in in_app_purchase, but doesn't (and can't in this PR).

I'm going to put a request-changes flag on the PR just to make sure nobody accidentally lands it as is. This is ready to be split into two PRs though (with the minor changes in my previous comment) for landing.

mchudy · 2025-01-20T09:55:39Z

I removed the JSON dependencies and moved the in_app_purchase package part to #8463

stuartmorgan-g

LGTM!

…tter/packages#8218)

flutter/packages@f73cb00...e8f1f63 2025-01-20 mchudy@users.noreply.github.com [in_app_purchase] Update Play Billing library to 7.1.1 (flutter/packages#8218) 2025-01-20 engine-flutter-autoroll@skia.org Roll Flutter from 5517cc9 to b9e86a5 (22 revisions) (flutter/packages#8458) 2025-01-18 stuartmorgan@google.com [pigeon] Update analyzer and formatter (flutter/packages#8456) 2025-01-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 3 directories with 1 update (flutter/packages#8328) 2025-01-17 magder@google.com [local_auth_darwin] Handle when FaceID hardware is available but permissions have been denied for the app (flutter/packages#8348) 2025-01-16 engine-flutter-autoroll@skia.org Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter/packages#8441) 2025-01-15 louisehsu@google.com [in_app_purchase_storekit] expose `jsonRepresentation` for Transactions (flutter/packages#8430) 2025-01-15 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 17025dd to 68415ad (4 revisions) (flutter/packages#8434) 2025-01-15 30872003+misos1@users.noreply.github.com [video_player_avfoundation] fix playback speed resetting (flutter/packages#7657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rchase (#8463) Extracted from #8218.

Updates Play Billing Library to the latest version 7.1.1. Exposes new APIs as per [release notes](https://developer.android.com/google/play/billing/release-notes): - Adds Dart representation of `ProductDetails.InstallmentPlanDetails` - Adds Dart representation of `PendingPurchasesParams` and removes the deprecated `enablePendingPurchases` method on `BillingClientWrapper` (breaking change) - Adds Dart representation of `Purchase.PendingPurchaseUpdate` - Removes the deprecated `ProrationMode` as it has been removed from the native library (breaking change) This PR introduces breaking changes in `in_app_purchase_android`, but does not introduce any breaking changes on the platform interface level. Fixes flutter/flutter#147394

…rchase (flutter#8463) Extracted from flutter#8218.

Updates Play Billing Library to the latest version 7.1.1. Exposes new APIs as per [release notes](https://developer.android.com/google/play/billing/release-notes): - Adds Dart representation of `ProductDetails.InstallmentPlanDetails` - Adds Dart representation of `PendingPurchasesParams` and removes the deprecated `enablePendingPurchases` method on `BillingClientWrapper` (breaking change) - Adds Dart representation of `Purchase.PendingPurchaseUpdate` - Removes the deprecated `ProrationMode` as it has been removed from the native library (breaking change) This PR introduces breaking changes in `in_app_purchase_android`, but does not introduce any breaking changes on the platform interface level. Fixes flutter/flutter#147394

…rchase (flutter#8463) Extracted from flutter#8218.

mchudy requested review from gmackall and bparrishMines as code owners December 3, 2024 22:26

mchudy changed the title ~~Feature/in app purchase play billing upgrade~~ [in_app_purchase] Update Play Billing library to 7.1.1 Dec 3, 2024

github-actions bot added p: in_app_purchase platform-android labels Dec 3, 2024

stuartmorgan-g requested a review from reidbaker December 17, 2024 20:43

reidbaker removed their request for review December 18, 2024 19:36

gmackall reviewed Jan 6, 2025

View reviewed changes

gmackall mentioned this pull request Jan 6, 2025

[gradle]: Bump com.android.billingclient:billing from 6.2.0 to 7.1.1 in /packages/in_app_purchase/in_app_purchase_android/android #8169

Closed

mchudy force-pushed the feature/in-app-purchase-play-billing-upgrade branch 3 times, most recently from 2ed01f3 to 4e5e3ca Compare January 6, 2025 23:50

mchudy requested a review from gmackall January 6, 2025 23:59

stuartmorgan-g added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Jan 9, 2025

stuartmorgan-g reviewed Jan 9, 2025

View reviewed changes

mchudy force-pushed the feature/in-app-purchase-play-billing-upgrade branch 2 times, most recently from 1273d51 to f7a56be Compare January 10, 2025 08:22

mchudy added 8 commits January 13, 2025 10:31

Upgrade Play Billing library to 7.1.1

c23348b

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

Remove proration mode references

0078d50

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

Add InstallmentPlanDetails model

ab5e118

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

Add installment plan details wrapper model

2c6f0ee

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

Remove ProrationMode enum

4312cf7

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

Update Android tests

ce29380

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

Add PendingPurchaseUpdate model

dbc0161

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

Fix formatting

cc9c473

Signed-off-by: Marcin Chudy <marcin.chudy@leancode.pl>

mchudy added 3 commits January 16, 2025 11:47

Remove JsonSerializable from PendingPurchasesParamsWrapper

dc4425c

Remove JSON serialization from other classes

b584ff2

Introduce Pigeon enums to avoid using hardcoded ints in Dart code

e9d8907

mchudy requested a review from stuartmorgan-g January 17, 2025 12:29

reidbaker approved these changes Jan 17, 2025

View reviewed changes

mchudy added 3 commits January 17, 2025 16:45

Bump in_app_purchase version

faec504

Fix formatting

9df2100

User patch version update

16df184

stuartmorgan-g reviewed Jan 17, 2025

View reviewed changes

stuartmorgan-g requested changes Jan 17, 2025

View reviewed changes

mchudy added 2 commits January 20, 2025 10:40

Remove json_serializable dependencies

7ab27c7

Revert in_app_purchase changes

ae5ccbd

mchudy mentioned this pull request Jan 20, 2025

[in_app_purchase] Update in_app_purchase_android version in in_app_purchase #8463

Merged

11 tasks

mchudy requested a review from stuartmorgan-g January 20, 2025 09:56

stuartmorgan-g approved these changes Jan 20, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 20, 2025

auto-submit bot merged commit e8f1f63 into flutter:main Jan 20, 2025
78 checks passed

engine-flutter-autoroll mentioned this pull request Jan 20, 2025

Roll Packages from f73cb00e127b to e8f1f63bc3b7 (9 revisions) flutter/flutter#161908

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 20, 2025

e8f1f63bc [in_app_purchase] Update Play Billing library to 7.1.1 (flu…

7802ac8

…tter/packages#8218)

engine-flutter-autoroll mentioned this pull request Jan 20, 2025

Roll Packages from f73cb00e127b to e8f1f63bc3b7 (9 revisions) flutter/flutter#161914

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 20, 2025

e8f1f63bc [in_app_purchase] Update Play Billing library to 7.1.1 (flu…

748fa0e

…tter/packages#8218)

auto-submit bot pushed a commit that referenced this pull request Jan 23, 2025

[in_app_purchase] Update in_app_purchase_android version in in_app_pu…

06abd68

…rchase (#8463) Extracted from #8218.

mchudy deleted the feature/in-app-purchase-play-billing-upgrade branch January 31, 2025 14:08

RobertOdrowaz mentioned this pull request Feb 14, 2025

[in_app_purchase] Remove JSON code from Android wrapper objects flutter/flutter#146202

Closed

androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025

[in_app_purchase] Update in_app_purchase_android version in in_app_pu…

2898a01

…rchase (flutter#8463) Extracted from flutter#8218.

FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025

[in_app_purchase] Update in_app_purchase_android version in in_app_pu…

52941a9

…rchase (flutter#8463) Extracted from flutter#8218.

[in_app_purchase] Update Play Billing library to 7.1.1 #8218

[in_app_purchase] Update Play Billing library to 7.1.1 #8218

Uh oh!

Conversation

mchudy commented Dec 3, 2024

Pre-launch Checklist

Uh oh!

stuartmorgan-g commented Dec 17, 2024

Uh oh!

reidbaker commented Dec 18, 2024

Uh oh!

wph144 commented Jan 6, 2025

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mchudy commented Jan 8, 2025

Uh oh!

stuartmorgan-g commented Jan 9, 2025

Uh oh!

stuartmorgan-g Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

reidbaker Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

mchudy commented Jan 20, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!