This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add word movement granularities to android #5902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on offline discussion, we will only include word for now since we don't have a way to support line/page/paragraph yet. |
|
|
You'd have to use ICU data to correctly determine word/line/etc breaks: http://icu-project.org/apiref/icu4c/classicu_1_1BreakIterator.html This is not fully exposed to dart land. If you do, be aware of this bug: flutter/flutter#19584 |
|
@goderbauer do you want to wait for that issue to be resolved before we add this to the framework? |
goderbauer
reviewed
Jul 30, 2018
| @@ -480,7 +490,17 @@ boolean performCursorMoveAction( | |||
| return true; | |||
| } | |||
| } | |||
| // TODO(goderbauer): support other granularities. | |||
| case AccessibilityNodeInfo.MOVEMENT_GRANULARITY_WORD: | |||
There was a problem hiding this comment.
Do the case statements need to end with break to avoid fall-through?
|
No, I wouldn't wait. |
jonahwilliams
changed the title
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jul 31, 2018
91ff524 Roll src/third_party/skia 74c6ed3d1f17..1935aa3d27cd (11 commits) (flutter/engine#5911) d06e9e8 Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (flutter/engine#18886) (flutter#5858) 3e6b681 Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter/engine#5910) 5b09e14 Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter/engine#5909) 236d633 Add word movement granularities to android (flutter/engine#5902) 5ae8240 Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter/engine#5908) 0c8fda2 Remove the "VSYNC" trace event on Fuchsia (flutter/engine#5907) 430ca29 Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter/engine#5906) 10effc7 Replace travis with cirrus (flutter/engine#5899) cd85329 Use container and GKE to accelerate build (flutter/engine#5897) 659e49e Add docker container generation scripts (flutter/engine#5898) 9336082 Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter/engine#5905) 46b7793 Clear the EGL context only if our context is currently active (flutter/engine#5895) 2f4a022 Return proper JSON-RPC error responses from service protocol failures (flutter/engine#5889) d34eb1d Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter/engine#5904)
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Mar 5, 2019
This brings the Dart and C++ semantics flag enums back in sync. In flutter#5902, the ability to move the cursor forward and backward one word were added to dart:ui, and to the embedders, but not to the SemanticsFlags enum on the C++ side. The resulting behaviour is unspecified by the standard (sec. 7.2/10).
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Mar 5, 2019
This brings the Dart and C++ semantics flag enums back in sync. In flutter#5902, the ability to move the cursor forward and backward one word were added to dart:ui, and to the embedders, but not to the SemanticsFlags enum on the C++ side.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Mar 5, 2019
This brings the Dart and C++ semantics flag enums back in sync. In flutter#5902, the ability to move the cursor forward and backward one word were added to dart:ui, and to the Android embedder, but not to the SemanticsAction enum on the C++ side.
cbracken
added a commit
that referenced
this pull request
Mar 5, 2019
This brings the Dart and C++ semantics flag enums back in sync. In #5902, the ability to move the cursor forward and backward one word were added to dart:ui, and to the Android embedder, but not to the SemanticsAction enum on the C++ side.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I image we can support word and line by looking for whitespace and newlines .... right?