-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
5f03628
to
2dffc65
Compare
.cirrus.yml
Outdated
@@ -25,3 +25,19 @@ build_android_task: | |||
./flutter/tools/gn --android --unoptimized | |||
ninja -C out/android_debug_unopt | |||
|
|||
old_travis_task: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this something else? It won't mean a whole lot in a couple of years when we haven't been using Travis for a long time...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks for the feedback! I also planned to reorganize those scripts inside travis/ folder and eventually remove or rename that directory. Hence part of the the reason (other than being lazy) to name it "old_travis" is to remind me to do such reorganization and eventually rename the task to something more meaningful :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, @gspencergoog , thanks! I copied it from my other scripts which requires gclient sync
because the content of engine/src/flutter is changed. Nothing changes here so there's no need to do gclient sync
. Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...wrong thread.
91ff524 Roll src/third_party/skia 74c6ed3d1f17..1935aa3d27cd (11 commits) (flutter/engine#5911) d06e9e8 Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (flutter/engine#18886) (flutter#5858) 3e6b681 Roll src/third_party/skia 0bf5408286ea..74c6ed3d1f17 (1 commits) (flutter/engine#5910) 5b09e14 Roll src/third_party/skia 946a162a5239..0bf5408286ea (1 commits) (flutter/engine#5909) 236d633 Add word movement granularities to android (flutter/engine#5902) 5ae8240 Roll src/third_party/skia f7dcd76c552a..946a162a5239 (3 commits) (flutter/engine#5908) 0c8fda2 Remove the "VSYNC" trace event on Fuchsia (flutter/engine#5907) 430ca29 Roll src/third_party/skia 62501c12c83e..f7dcd76c552a (5 commits) (flutter/engine#5906) 10effc7 Replace travis with cirrus (flutter/engine#5899) cd85329 Use container and GKE to accelerate build (flutter/engine#5897) 659e49e Add docker container generation scripts (flutter/engine#5898) 9336082 Roll src/third_party/skia c06b8a4e0ca3..62501c12c83e (11 commits) (flutter/engine#5905) 46b7793 Clear the EGL context only if our context is currently active (flutter/engine#5895) 2f4a022 Return proper JSON-RPC error responses from service protocol failures (flutter/engine#5889) d34eb1d Roll src/third_party/skia 227424b57d28..c06b8a4e0ca3 (22 commits) (flutter/engine#5904)
Using a custom container image, we reduce the test time from 5 minutes to 2 minutes as we no longer run
gclient sync
from zero.In the future, we may be able to cache the
ninja
output in the image (which probably gets updated daily) so we no longer compile from zero.