This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Reland [skwasm] Scene builder optimizations for platform view placement (#55468)" #55715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… placement (flutter#55468)" This reverts commit def85c7.
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2024
…tform view placement (flutter#55468)" (flutter/engine#55715)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2024
…tform view placement (flutter#55468)" (flutter/engine#55715)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2024
…156379) flutter/engine@e096ddb...07c702f 2024-10-08 ditman@gmail.com [web] Warn users when picking a deprecated renderer. (flutter/engine#55709) 2024-10-08 jacksongardner@google.com Revert "Reland [skwasm] Scene builder optimizations for platform view placement (#55468)" (flutter/engine#55715) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Oct 8, 2024
eyebrowsoffire
added a commit
to eyebrowsoffire/engine
that referenced
this pull request
Oct 23, 2024
…w placement (flutter#55468)" (flutter#55715) This reverts commit 7d56a8c.
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
… placement (flutter#55468)" (flutter/engine#55715) This reverts commit b99e758 (flutter/engine#55468) Reason for revert, devtools has been having rendering issues since this commit. See flutter/devtools#8401
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit def85c7 (#55468)
Reason for revert, devtools has been having rendering issues since this commit. See flutter/devtools#8401