This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland [skwasm] Scene builder optimizations for platform view placement #55468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to reland the overlay optimization for skwasm and fixing the golden diffs from the framework tests. Original PR description: This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: flutter/flutter#149863 This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
eyebrowsoffire
force-pushed
the
skwasm_platform_view_opt_reland
branch
from
a9adba2 to
0a20de5
Compare
eyebrowsoffire
added a commit
to eyebrowsoffire/flutter
that referenced
this pull request
Sep 26, 2024
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
LGTM with small nit in test |
harryterkelsen
approved these changes
Sep 27, 2024
| @@ -3,6 +3,7 @@ | |||
| // found in the LICENSE file. | |||
|
|
|||
| import 'dart:math' as math; | |||
| import 'dart:math'; | |||
There was a problem hiding this comment.
use the other import
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 30, 2024
…155952) flutter/engine@b466a0d...e61bc85 2024-09-30 art-snake@yandex-team.ru fix use_of_uninitialized_value in message_loop_task_queues.cc (flutter/engine#55520) 2024-09-30 chris@bracken.jp iOS: Migrate FlutterEngineGroup to ARC (flutter/engine#55503) 2024-09-30 jacksongardner@google.com Reland [skwasm] Scene builder optimizations for platform view placement (flutter/engine#55468) 2024-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from c55ae50d619a to 79863e31de87 (1 revision) (flutter/engine#55525) 2024-09-30 skia-flutter-autoroll@skia.org Roll Skia from 06721a724831 to dfeeb199b226 (2 revisions) (flutter/engine#55524) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Oct 1, 2024
…lutter#155952) flutter/engine@b466a0d...e61bc85 2024-09-30 art-snake@yandex-team.ru fix use_of_uninitialized_value in message_loop_task_queues.cc (flutter/engine#55520) 2024-09-30 chris@bracken.jp iOS: Migrate FlutterEngineGroup to ARC (flutter/engine#55503) 2024-09-30 jacksongardner@google.com Reland [skwasm] Scene builder optimizations for platform view placement (flutter/engine#55468) 2024-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from c55ae50d619a to 79863e31de87 (1 revision) (flutter/engine#55525) 2024-09-30 skia-flutter-autoroll@skia.org Roll Skia from 06721a724831 to dfeeb199b226 (2 revisions) (flutter/engine#55524) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
eyebrowsoffire
added a commit
to eyebrowsoffire/engine
that referenced
this pull request
Oct 7, 2024
… placement (flutter#55468)" This reverts commit def85c7.
This was referenced Oct 7, 2024
Merged
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
… placement (#55468)" (#55715) This reverts commit def85c7 (#55468) Reason for revert, devtools has been having rendering issues since this commit. See flutter/devtools#8401
eyebrowsoffire
added a commit
to eyebrowsoffire/engine
that referenced
this pull request
Oct 23, 2024
…w placement (flutter#55468)" (flutter#55715) This reverts commit 7d56a8c.
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
This is an attempt to reland #55468 We now defer actually drawing the pictures until the build of the layer slices, so that we can calculate an accurate `cullRect` for the picture recorder This also contains a further optimization for the "simple" rendering case (no platform views) where we don't actually do any unnecessary occlusion calculations.
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
… placement (flutter#55468)" (flutter/engine#55715) This reverts commit b99e758 (flutter/engine#55468) Reason for revert, devtools has been having rendering issues since this commit. See flutter/devtools#8401
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This is an attempt to reland flutter/engine#55468 We now defer actually drawing the pictures until the build of the layer slices, so that we can calculate an accurate `cullRect` for the picture recorder This also contains a further optimization for the "simple" rendering case (no platform views) where we don't actually do any unnecessary occlusion calculations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to reland the overlay optimization for skwasm and fixing the golden diffs from the framework tests.
Original PR description:
This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: flutter/flutter#149863
This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.