[Impeller] dont use blend shader for simple drawAtlas calls. #55420
Conversation
|
|
||
| namespace impeller { | ||
|
|
||
| /// @brief A geometry that is created from a DlVertices object. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
I will add some unit tests of the vertex computations. |
…ne into mke_draw_atlas_faster
|
Unit tests adde |
jonahwilliams
added
the
autosubmit
|
auto label is removed for flutter/engine/55420, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
jonahwilliams
added
the
autosubmit
|
auto label is removed for flutter/engine/55420, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
jonahwilliams
added
the
autosubmit
…155811) flutter/engine@e57b440...7c603de 2024-09-27 skia-flutter-autoroll@skia.org Roll Skia from 9ebb7c3640a1 to e77818421e91 (4 revisions) (flutter/engine#55479) 2024-09-27 jonahwilliams@google.com [ci] make opengles impeller scenario app non-bringup (flutter/engine#55474) 2024-09-27 jonahwilliams@google.com [Impeller] dont use blend shader for simple drawAtlas calls. (flutter/engine#55420) 2024-09-27 valentin.haloiu@gmail.com Add `format` field to EGL surface backing store (flutter/engine#54499) 2024-09-26 jonahwilliams@google.com [Impeller] avoid reading font while parsing sktextblob. (flutter/engine#55442) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
When making a drawAtlas call with no colors, use the faster shader that does not apply blending.
Now that we're switched to experimental canvas, we can remove the copying of the display list data. The draw can directly refer to pointers from the display list structure, as the draw is processed during DL dispatching.