Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e57b440ec4ee
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7c603de2dca7
Choose a head ref
  • 5 commits
  • 21 files changed
  • 3 contributors

Commits on Sep 26, 2024

  1. [Impeller] avoid reading font while parsing sktextblob. (#55442)

    Use a faster approximation for finding out axis alignment that skips opening the font file, which is slow!
    
    ![image](https://github.com/user-attachments/assets/ae840597-b63b-4e46-b857-ac5f09e09ca8)
    Jonah Williams authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9d1566d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Add format field to EGL surface backing store (#54499)

    Trying to use the `GL_BGRA8_EXT` format for the EGL surface backing store on *desktop* OpenGL platforms would fail at: https://github.com/flutter/engine/blob/bde314b856850155d0678632b62c23c84f49afab/shell/platform/embedder/embedder.cc#L869
    
    This seems to be a known issue and both the Linux and Windows embedders have some logic to pick a different format depending on the OpenGL context information:
    
    https://github.com/flutter/engine/blob/088dcfa6cf934088413c5d8af754de1ef7b0d1ca/shell/platform/windows/compositor_opengl.cc#L23-L34
    
    https://github.com/flutter/engine/blob/088dcfa6cf934088413c5d8af754de1ef7b0d1ca/shell/platform/linux/fl_framebuffer.cc#L81-L104
    
    This pull-request gets rid of the hard-coded `GL_BGRA8_EXT` format and makes it configurable by adding a `format` field to the `FlutterOpenGLSurface` struct.
    
    _Disclaimer_: This has only been tested on desktop Linux (Wayland) using the `GR_GL_RGBA8` format which seemed to work as expected.
    
    This change is related to the recently introduced EGL surface backing store: flutter/flutter#58363
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    vially authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    01bfe76 View commit details
    Browse the repository at this point in the history
  2. [Impeller] dont use blend shader for simple drawAtlas calls. (#55420)

    When making a drawAtlas call with no colors, use the faster shader that does not apply blending.
    
    Now that we're switched to experimental canvas, we can remove the copying of the display list data. The draw can directly refer to pointers from the display list structure, as the draw is processed during DL dispatching.
    Jonah Williams authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    feae968 View commit details
    Browse the repository at this point in the history
  3. [ci] make opengles impeller scenario app non-bringup (#55474)

    This is passing consistently now.
    Jonah Williams authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    42d1a37 View commit details
    Browse the repository at this point in the history
  4. Roll Skia from 9ebb7c3640a1 to e77818421e91 (4 revisions) (#55479)

    https://skia.googlesource.com/skia.git/+log/9ebb7c3640a1..e77818421e91
    
    2024-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c13e7159cdd1 to 3ba9cd40c151 (4 revisions)
    2024-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3eee2be83d3f to cef41cc71c85 (6 revisions)
    2024-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8d76160610aa to 64d149df26fd (12 revisions)
    2024-09-26 bungeman@google.com Allow multiple equivalent "clang version"s
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC bdero@google.com,brianosman@google.com,bungeman@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7c603de View commit details
    Browse the repository at this point in the history
Loading