This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[et] Better RBE defaults #54059
Merged
[et] Better RBE defaults #54059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
force-pushed
the
et-rbe-config
branch
2 times, most recently
from
e92f7dd to
4b6479a
Compare
cbracken
reviewed
Jul 24, 2024
cbracken
reviewed
Jul 24, 2024
tools/pkg/engine_build_configs/test/build_config_runner_test.dart
Outdated
Show resolved
Hide resolved
cbracken
reviewed
Jul 24, 2024
tools/pkg/engine_build_configs/test/build_config_runner_test.dart
Outdated
Show resolved
Hide resolved
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 25, 2024
…152293) flutter/engine@eb8fac2...a57655c 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Jul 25, 2024
…isions) (#152293)" (#152304) Reverts: #152293 Initiated by: zanderso Reason for reverting: Failing framework test https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_views_scroll_perf_ad_banners__timeline_summary/956/overview Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@eb8fac2...a57655c 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 25, 2024
…ions) (#152305) Manual roll requested by zra@google.com flutter/engine@eb8fac2...7473782 2024-07-25 yjbanov@google.com [web] better class names for semantics (flutter/engine#54070) 2024-07-25 jonahwilliams@google.com Disable FlutterMetalLayer by default. (flutter/engine#54095) 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152293) flutter/engine@eb8fac2...a57655c 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…isions) (flutter#152293)" (flutter#152304) Reverts: flutter#152293 Initiated by: zanderso Reason for reverting: Failing framework test https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_views_scroll_perf_ad_banners__timeline_summary/956/overview Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@eb8fac2...a57655c 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…ions) (flutter#152305) Manual roll requested by zra@google.com flutter/engine@eb8fac2...7473782 2024-07-25 yjbanov@google.com [web] better class names for semantics (flutter/engine#54070) 2024-07-25 jonahwilliams@google.com Disable FlutterMetalLayer by default. (flutter/engine#54095) 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152293) flutter/engine@eb8fac2...a57655c 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…isions) (flutter#152293)" (flutter#152304) Reverts: flutter#152293 Initiated by: zanderso Reason for reverting: Failing framework test https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_views_scroll_perf_ad_banners__timeline_summary/956/overview Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@eb8fac2...a57655c 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…ions) (flutter#152305) Manual roll requested by zra@google.com flutter/engine@eb8fac2...7473782 2024-07-25 yjbanov@google.com [web] better class names for semantics (flutter/engine#54070) 2024-07-25 jonahwilliams@google.com Disable FlutterMetalLayer by default. (flutter/engine#54095) 2024-07-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (flutter/engine#54092) 2024-07-25 gspencergoog@users.noreply.github.com Remove incorrect line (flutter/engine#54021) 2024-07-24 zanderso@users.noreply.github.com [et] Better RBE defaults (flutter/engine#54059) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (flutter/engine#54091) 2024-07-24 jonahwilliams@google.com [iOS] Switch to FlutterMetalLayer by default. (flutter/engine#54086) 2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (flutter/engine#54089) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts some RBE configuration from the way that chromium uses RBE
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/refs/heads/main/reclient_helper.py
These changes should bias both local and CI builds more towards using the worker pool, which we recently expanded, and should help limit the bandwidth used, which is a bottleneck for build times on a slow connection.