-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: eb8fac2b1703
head repository: flutter/engine
compare: 74737820a8ee
- 8 commits
- 36 files changed
- 5 contributors
Commits on Jul 24, 2024
-
Roll Skia from 54d1434637a1 to 55ecdde3a5fa (3 revisions) (#54089)
https://skia.googlesource.com/skia.git/+log/54d1434637a1..55ecdde3a5fa 2024-07-24 jvanverth@google.com Update comment in patheffects.cpp. 2024-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 52a246a737a2 to a6d9a7de5704 2024-07-24 robertphillips@google.com [graphite] Add comments to public API re Graphite-specific deprecations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 511a8ef - Browse repository at this point
Copy the full SHA 511a8efView commit details -
[iOS] Switch to FlutterMetalLayer by default. (#54086)
For this to work, we need to provide our own capture scope otherwise the default scope won't capture our commands. This is required as part of the work to switch to unmerged threads for PVs (#53826), as I can confirm @knopp 's observations that the performance is much worse with the default CAMetalLayer. Fixes flutter/flutter#140901
Jonah Williams authoredJul 24, 2024 Configuration menu - View commit details
-
Copy full SHA for e1259b8 - Browse repository at this point
Copy the full SHA e1259b8View commit details -
Roll Skia from 55ecdde3a5fa to 746d444f3efd (2 revisions) (#54091)
https://skia.googlesource.com/skia.git/+log/55ecdde3a5fa..746d444f3efd 2024-07-24 johnstiles@google.com Avoid using optional<> for ModuleType. 2024-07-24 johnstiles@google.com Add Analysis::FindSpecializedArgumentsForCall helper function. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 95e9885 - Browse repository at this point
Copy the full SHA 95e9885View commit details -
[et] Better RBE defaults (#54059)
This PR adopts some RBE configuration from the way that chromium uses RBE https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/refs/heads/main/reclient_helper.py These changes should bias both local and CI builds more towards using the worker pool, which we recently expanded, and should help limit the bandwidth used, which is a bottleneck for build times on a slow connection.
Configuration menu - View commit details
-
Copy full SHA for 97b5c95 - Browse repository at this point
Copy the full SHA 97b5c95View commit details
Commits on Jul 25, 2024
-
Remove incorrect line (#54021)
## Description Removes a line that shadows setting the device type correctly for keyboard events. ## Related Issues - Fixes flutter/flutter#151308
Configuration menu - View commit details
-
Copy full SHA for 805a157 - Browse repository at this point
Copy the full SHA 805a157View commit details -
Roll Dart SDK from 0b3c00feefb1 to 693848f200d7 (1 revision) (#54092)
https://dart.googlesource.com/sdk.git/+log/0b3c00feefb1..693848f200d7 2024-07-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-78.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for a57655c - Browse repository at this point
Copy the full SHA a57655cView commit details -
Disable FlutterMetalLayer by default. (#54095)
Backing textures aren't getting deallocated, which is causing memory leaks and crashing devicelab.
Jonah Williams authoredJul 25, 2024 Configuration menu - View commit details
-
Copy full SHA for f4f0bf3 - Browse repository at this point
Copy the full SHA f4f0bf3View commit details -
[web] better class names for semantics (#54070)
A few non-functional clean-ups in semantics: * Rename `RoleManager` to `SemanticBehavior`. * Rename `PrimaryRoleManager` to `SemanticRole`. * Remove the `Role` enum. Move the enum docs into the respective classes. ## Why? Previous naming was confusing. It's not clear what the difference is between a "role manager" and a "primary role manager". The word "manager" is a meaningless addition; the `Semantic*` prefix is much more meaningful. The `Role` enum was only used for tests, but tests can just use `SemanticRole.runtimeType`. ## New state of the world After this PR the semantics system has "objects" (class `SemanticsObject`), "roles" (class `SemanticRole`), and "behaviors" (class `SemanticBehavior`). - A semantic _object_ is an object attached to the framework-side `SemanticNode`. It lives as long as the semantic node does, and provides basic functionality that's common across all nodes. - A semantic object has exactly one semantic _role_. This role is determined from the flags set on the semantic node. Flags can change, causing a semantic object to change its role, which is why these are two separate classes. If an object had just one permanent role, we could combine these classes into one (maybe one day we'll do it, as changing roles dynamically is weird, but that needs major changes in the framework). - A semantic role may have zero or more semantic _behaviors_. A behavior supplies a piece of functionality, such as focusability, clickability/tappability, live regions, etc. A behavior can be shared by multiple roles. For example, both `Button` and `Checkable` roles use the `Tappable` behavior. This is why there's a many-to-many relationship between roles and behaviors. Or in entity relationship terms: ```mermaid --- title: Semantic object relationships --- erDiagram SemanticsNode ||--|| SemanticsObject : managed-by SemanticsObject ||--o{ SemanticRole : has-a SemanticRole }o--o{ SemanticBehavior : has ```
Configuration menu - View commit details
-
Copy full SHA for 7473782 - Browse repository at this point
Copy the full SHA 7473782View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff eb8fac2b1703...74737820a8ee