This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add doc comments to build/archives/BUILD.gn #53973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Jul 17, 2024
The existing comment on gen_snapshot is unclear. Adds comments where they were missing. Saves future readers some digging through git blame.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 18, 2024
…151925) flutter/engine@a5a93bb...d194a2f 2024-07-17 skia-flutter-autoroll@skia.org Roll Skia from 546120aeaa44 to e7844530e828 (1 revision) (flutter/engine#53976) 2024-07-17 chris@bracken.jp Add doc comments to build/archives/BUILD.gn (flutter/engine#53973) 2024-07-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d679a4c98193 to 9b9ca1ff944d (1 revision) (flutter/engine#53975) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#151925) flutter/engine@a5a93bb...d194a2f 2024-07-17 skia-flutter-autoroll@skia.org Roll Skia from 546120aeaa44 to e7844530e828 (1 revision) (flutter/engine#53976) 2024-07-17 chris@bracken.jp Add doc comments to build/archives/BUILD.gn (flutter/engine#53973) 2024-07-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d679a4c98193 to 9b9ca1ff944d (1 revision) (flutter/engine#53975) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#151925) flutter/engine@a5a93bb...d194a2f 2024-07-17 skia-flutter-autoroll@skia.org Roll Skia from 546120aeaa44 to e7844530e828 (1 revision) (flutter/engine#53976) 2024-07-17 chris@bracken.jp Add doc comments to build/archives/BUILD.gn (flutter/engine#53973) 2024-07-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d679a4c98193 to 9b9ca1ff944d (1 revision) (flutter/engine#53975) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing comment on gen_snapshot is unclear. Adds comments where they were missing. Saves future readers some digging through git blame.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.