Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 700f8af

Browse files
authored
Add doc comments to build/archives/BUILD.gn (#53973)
The existing comment on gen_snapshot is unclear. Adds comments where they were missing. Saves future readers some digging through git blame. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 8b089a8 commit 700f8af

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

build/archives/BUILD.gn

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,16 @@ if (build_engine_artifacts && !is_android) {
5353
exe = ".exe"
5454
}
5555

56-
# Only include gen_snapshot for all runtime modes.
56+
# gen_snapshot is bundled for all runtime modes.
5757
files = [
5858
{
5959
source = "$root_out_dir/gen_snapshot$exe"
6060
destination = "gen_snapshot$exe"
6161
},
6262
]
63+
64+
# Host tooling/libraries that are used only in debug builds, or which are
65+
# identical across all runtime modes.
6366
if (flutter_runtime_mode == "debug") {
6467
dll = ".so"
6568
lib_prefix = "lib"
@@ -109,6 +112,9 @@ if (build_engine_artifacts && !is_android) {
109112
},
110113
]
111114
}
115+
116+
# On macOS, add entitlements.txt, which contains filenames of binaries that
117+
# need to be code-signed by a later CI stage.
112118
if (host_os == "mac") {
113119
deps += [ ":artifacts_entitlement_config" ]
114120
files += [

0 commit comments

Comments
 (0)