[Impeller] Exploit dynamic state in OpenGL for fewer program links. #53764

chinmaygarde · 2024-07-08T19:46:32Z

chinmaygarde · 2024-07-08T19:47:09Z

No change in functionality. Reduces the compilation and link load at runtime.

jonahwilliams · 2024-07-08T20:10:22Z

Can we test this in someway? For example, ask for a pipeline - then ask for a variant. Assert they have the same backing program?

chinmaygarde · 2024-07-08T21:02:22Z

Yup. Added a test. There are goldens that should cover this and an earlier version of this patch did break advanced blends because I forgot about spec. constants. But having a non-golden test that checks for program equality makes sense and I've added that.

impeller/renderer/backend/gles/test/pipeline_library_gles_unittests.cc

jonahwilliams · 2024-07-08T21:07:17Z

impeller/renderer/backend/gles/test/pipeline_library_gles_unittests.cc

+  // The program handles should be live and equal.
+  ASSERT_FALSE(pipeline_gles.GetProgramHandle().IsDead());
+  ASSERT_FALSE(new_pipeline_gles.GetProgramHandle().IsDead());
+  ASSERT_EQ(pipeline_gles.GetProgramHandle().name.value(),


Note for readers: the name is actually a unique ID, so its not like an arbitrary string or something like that.

jonahwilliams

LGTM

chinmaygarde · 2024-07-08T21:23:12Z

Added a test that asserts that changing a spec. constant creates a new program object.

bdero

Nice one, LGTM

auto-submit · 2024-07-08T21:50:35Z

auto label is removed for flutter/engine/53764, due to - The status or check suite Mac mac_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

…m links. (flutter/engine#53764)

…151482) flutter/engine@69075e7...4a2ac0e 2024-07-09 bdero@google.com Revert 4 Dart rolls (726cb2467 -> ffc8bb004) to recover engine roll (flutter/engine#53778) 2024-07-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 33b65d2fe034 to 726cb2467f27 (1 revision) (flutter/engine#53776) 2024-07-09 skia-flutter-autoroll@skia.org Roll Skia from 9a6f8dfb9102 to 46e5bf98158a (1 revision) (flutter/engine#53775) 2024-07-09 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.3 to 4.3.4 (flutter/engine#53774) 2024-07-09 skia-flutter-autoroll@skia.org Roll Skia from ced941fdddc4 to 9a6f8dfb9102 (1 revision) (flutter/engine#53773) 2024-07-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 0ecada960645 to 33b65d2fe034 (2 revisions) (flutter/engine#53772) 2024-07-09 skia-flutter-autoroll@skia.org Roll Skia from 9edafde22cb3 to ced941fdddc4 (2 revisions) (flutter/engine#53769) 2024-07-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 1679aba20a03 to 0ecada960645 (1 revision) (flutter/engine#53767) 2024-07-08 dustingreen@google.com [fuchsia][sysmem2] move to sysmem2 protocols (flutter/engine#53138) 2024-07-08 chinmaygarde@google.com [Impeller] Exploit dynamic state in OpenGL for fewer program links. (flutter/engine#53764) 2024-07-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Em1nantnFXXK8xJH9... to yYs6rINJxWJ8J2vxo... (flutter/engine#53763) 2024-07-08 jonahwilliams@google.com [Impeller] fix incorrect padding/translation in drawVertices with texture coordinates. (flutter/engine#53746) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from c65710d00047 to 9edafde22cb3 (3 revisions) (flutter/engine#53762) 2024-07-08 jonahwilliams@google.com [Impeller] implement clear color opt for experimental canvas. (flutter/engine#53749) 2024-07-08 jonahwilliams@google.com [Impeller] add experimental canvas support to screenshotter. (flutter/engine#53751) 2024-07-08 chinmaygarde@google.com Add a host_debug_unopt local engine config for Windows. (flutter/engine#53734) 2024-07-08 skia-flutter-autoroll@skia.org Roll Dart SDK from ffc8bb004a64 to 1679aba20a03 (16 revisions) (flutter/engine#53761) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from 38b17b22312d to c65710d00047 (2 revisions) (flutter/engine#53758) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from b2c51b2fe15f to 38b17b22312d (1 revision) (flutter/engine#53757) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from 1f85fb9238aa to b2c51b2fe15f (3 revisions) (flutter/engine#53756) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from f1d06de0ae87 to 1f85fb9238aa (2 revisions) (flutter/engine#53753) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Em1nantnFXXK to yYs6rINJxWJ8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[Impeller] Exploit dynamic state in OpenGL for fewer program links.

0b86b4b

Fixes flutter/flutter#145125 PR PR

chinmaygarde requested review from bdero and jonahwilliams July 8, 2024 19:46

This comment was marked as outdated.

Sign in to view

github-actions bot added the e: impeller label Jul 8, 2024

chinmaygarde added the e: opengl label Jul 8, 2024

chinmaygarde self-assigned this Jul 8, 2024

chinmaygarde added 3 commits July 8, 2024 13:25

Licenses.

05132b0

Clang Tidy.

e5c1e89

Test.

052f143

jonahwilliams reviewed Jul 8, 2024

View reviewed changes

impeller/renderer/backend/gles/test/pipeline_library_gles_unittests.cc Show resolved Hide resolved

jonahwilliams reviewed Jul 8, 2024

View reviewed changes

jonahwilliams approved these changes Jul 8, 2024

View reviewed changes

Spec. constant test.

3b3e4be

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2024

bdero approved these changes Jul 8, 2024

View reviewed changes

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2024

Linter doesn't understand gtest assertions.

be0f994

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2024

auto-submit bot merged commit a3ba6c9 into flutter:main Jul 8, 2024
31 checks passed

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to a3ba6c9c0d39 (12 revisions) flutter/flutter#151442

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

36d6a6d

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to 14e0ac632ecb (14 revisions) flutter/flutter#151443

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

1cc1e00

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to bfaac836c381 (15 revisions) flutter/flutter#151445

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

8d5d4ba

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to bfaac836c381 (15 revisions) flutter/flutter#151450

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

6626f74

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to 3e17ca21f973 (16 revisions) flutter/flutter#151455

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

9ed8660

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to 0de528ad88f6 (17 revisions) flutter/flutter#151458

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

a3f1d18

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to 6651c75dbae3 (19 revisions) flutter/flutter#151462

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

79f1ddd

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to 6651c75dbae3 (19 revisions) flutter/flutter#151466

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

60a0dcd

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to 84e2dc32c6f2 (20 revisions) flutter/flutter#151470

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

0a6458d

…m links. (flutter/engine#53764)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to 84e2dc32c6f2 (20 revisions) flutter/flutter#151476

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

6639856

…m links. (flutter/engine#53764)

chinmaygarde deleted the fewerlinks branch July 9, 2024 18:31

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter Engine from 69075e7e87d4 to 4a2ac0e51a8f (21 revisions) flutter/flutter#151482

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2024

a3ba6c9c0 [Impeller] Exploit dynamic state in OpenGL for fewer progra…

0291b0a

…m links. (flutter/engine#53764)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Exploit dynamic state in OpenGL for fewer program links. #53764

[Impeller] Exploit dynamic state in OpenGL for fewer program links. #53764

Uh oh!

chinmaygarde commented Jul 8, 2024

Uh oh!

This comment was marked as outdated.

chinmaygarde commented Jul 8, 2024

Uh oh!

jonahwilliams commented Jul 8, 2024

Uh oh!

chinmaygarde commented Jul 8, 2024 •

edited

Loading

Uh oh!

Uh oh!

jonahwilliams Jul 8, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

chinmaygarde commented Jul 8, 2024

Uh oh!

bdero left a comment

Uh oh!

auto-submit bot commented Jul 8, 2024

Uh oh!

Uh oh!

Uh oh!

[Impeller] Exploit dynamic state in OpenGL for fewer program links. #53764

[Impeller] Exploit dynamic state in OpenGL for fewer program links. #53764

Uh oh!

Conversation

chinmaygarde commented Jul 8, 2024

Uh oh!

This comment was marked as outdated.

chinmaygarde commented Jul 8, 2024

Uh oh!

jonahwilliams commented Jul 8, 2024

Uh oh!

chinmaygarde commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jonahwilliams Jul 8, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Jul 8, 2024

Uh oh!

bdero left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jul 8, 2024

Uh oh!

Uh oh!

Uh oh!

chinmaygarde commented Jul 8, 2024 •

edited

Loading