This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] implement clear color opt for experimental canvas. #53749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
suggested changes
Jul 8, 2024
impeller/renderer/render_target.cc
Outdated
| @@ -209,6 +209,10 @@ const std::optional<StencilAttachment>& RenderTarget::GetStencilAttachment() | |||
| return stencil_; | |||
| } | |||
|
|
|||
| ColorAttachment& RenderTarget::GetColorAttachment(size_t index) { | |||
There was a problem hiding this comment.
The index is being ignored. You're always going to get 0u.
There was a problem hiding this comment.
On second thought, this seems like an unnecessary API change. You can GetColorAttachments to fetch the attachment, modify it as necessary, and then SetColorAttachment.
There was a problem hiding this comment.
Yeah good point, I would need to modify the map to not be const though
There was a problem hiding this comment.
SetColorAttachment should do the trick right?
There was a problem hiding this comment.
Yeah that will work!
chinmaygarde
approved these changes
Jul 8, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 9, 2024
…151482) flutter/engine@69075e7...4a2ac0e 2024-07-09 bdero@google.com Revert 4 Dart rolls (726cb2467 -> ffc8bb004) to recover engine roll (flutter/engine#53778) 2024-07-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 33b65d2fe034 to 726cb2467f27 (1 revision) (flutter/engine#53776) 2024-07-09 skia-flutter-autoroll@skia.org Roll Skia from 9a6f8dfb9102 to 46e5bf98158a (1 revision) (flutter/engine#53775) 2024-07-09 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.3 to 4.3.4 (flutter/engine#53774) 2024-07-09 skia-flutter-autoroll@skia.org Roll Skia from ced941fdddc4 to 9a6f8dfb9102 (1 revision) (flutter/engine#53773) 2024-07-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 0ecada960645 to 33b65d2fe034 (2 revisions) (flutter/engine#53772) 2024-07-09 skia-flutter-autoroll@skia.org Roll Skia from 9edafde22cb3 to ced941fdddc4 (2 revisions) (flutter/engine#53769) 2024-07-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 1679aba20a03 to 0ecada960645 (1 revision) (flutter/engine#53767) 2024-07-08 dustingreen@google.com [fuchsia][sysmem2] move to sysmem2 protocols (flutter/engine#53138) 2024-07-08 chinmaygarde@google.com [Impeller] Exploit dynamic state in OpenGL for fewer program links. (flutter/engine#53764) 2024-07-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Em1nantnFXXK8xJH9... to yYs6rINJxWJ8J2vxo... (flutter/engine#53763) 2024-07-08 jonahwilliams@google.com [Impeller] fix incorrect padding/translation in drawVertices with texture coordinates. (flutter/engine#53746) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from c65710d00047 to 9edafde22cb3 (3 revisions) (flutter/engine#53762) 2024-07-08 jonahwilliams@google.com [Impeller] implement clear color opt for experimental canvas. (flutter/engine#53749) 2024-07-08 jonahwilliams@google.com [Impeller] add experimental canvas support to screenshotter. (flutter/engine#53751) 2024-07-08 chinmaygarde@google.com Add a host_debug_unopt local engine config for Windows. (flutter/engine#53734) 2024-07-08 skia-flutter-autoroll@skia.org Roll Dart SDK from ffc8bb004a64 to 1679aba20a03 (16 revisions) (flutter/engine#53761) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from 38b17b22312d to c65710d00047 (2 revisions) (flutter/engine#53758) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from b2c51b2fe15f to 38b17b22312d (1 revision) (flutter/engine#53757) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from 1f85fb9238aa to b2c51b2fe15f (3 revisions) (flutter/engine#53756) 2024-07-08 skia-flutter-autoroll@skia.org Roll Skia from f1d06de0ae87 to 1f85fb9238aa (2 revisions) (flutter/engine#53753) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Em1nantnFXXK to yYs6rINJxWJ8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#150995
Rather than using a separate state bit, we can use whether the current render pass is active as an indicator for whether or not it is safe to apply the clear color optimization.