Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] write glyphs to malloc buffer. #52937

Merged
merged 1 commit into from
May 20, 2024

Conversation

jonahwilliams
Copy link
Member

Writing to a malloc buffer and then copying is faster on a variety of Pixel devices. Since this change was supposed to be a performance optimization, just back it out.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams
Copy link
Member Author

Fixes flutter/flutter#147996

(Not because we did it, because we don't need it)

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit auto-submit bot merged commit 6264763 into flutter:main May 20, 2024
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 21, 2024
…148766)

flutter/engine@c2ef01f...8a352f0

2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from c6bb2106c13b to e0881f06f94a (1 revision) (flutter/engine#52954)
2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from cb763e4dad50 to dd768e0d1890 (1 revision) (flutter/engine#52953)
2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 2102f791405c to c6bb2106c13b (1 revision) (flutter/engine#52952)
2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 1a52d4d5f45e to 2102f791405c (1 revision) (flutter/engine#52951)
2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 97d3b45d6b00 to 1a52d4d5f45e (1 revision) (flutter/engine#52947)
2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from d1a786ef6888 to cb763e4dad50 (1 revision) (flutter/engine#52950)
2024-05-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.13.4 to 3.25.6 (flutter/engine#52949)
2024-05-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.5 to 4.1.6 (flutter/engine#52948)
2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 62f369c75994 to 97d3b45d6b00 (1 revision) (flutter/engine#52946)
2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 01a77883e9e9 to d1a786ef6888 (1 revision) (flutter/engine#52945)
2024-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jXE7fqJI6VWFMaIdV... to HHwlAJN5imwf3yX4i... (flutter/engine#52944)
2024-05-21 bdero@google.com [Impeller] Reland: Remove Entity capture/AiksInspector. (flutter/engine#52932)
2024-05-20 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Refactor HtmlImageCodec to generalize to different renderers (flutter/engine#52905)
2024-05-20 skia-flutter-autoroll@skia.org Roll Skia from 977a43773f7c to 62f369c75994 (1 revision) (flutter/engine#52941)
2024-05-20 skia-flutter-autoroll@skia.org Roll Skia from 0b8d8ce44d1f to 977a43773f7c (1 revision) (flutter/engine#52938)
2024-05-20 jonahwilliams@google.com [Impeller] write glyphs to malloc buffer. (flutter/engine#52937)
2024-05-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 08f4324c988b to 01a77883e9e9 (1 revision) (flutter/engine#52936)
2024-05-20 bdero@google.com [Impeller] Fix use-after-move in SwapchainVK. (flutter/engine#52933)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from jXE7fqJI6VWF to HHwlAJN5imwf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants