[canvaskit] Refactor HtmlImageCodec to generalize to different renderers #52905

harryterkelsen · 2024-05-17T18:04:17Z

Refactor HtmlImageCodec to decouple it from the html renderer so other renderers can create a ui.Image via Image.decode().

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

yjbanov

yjbanov · 2024-05-20T21:42:51Z

lib/web_ui/lib/src/engine/html_image_element_codec.dart

 final bool _supportsDecode = _jsImageDecodeFunction != null;

 // TODO(mdebbar): Deprecate this and remove it.
 // https://github.com/flutter/flutter/issues/127395
 typedef WebOnlyImageCodecChunkCallback = ui_web.ImageCodecChunkCallback;

-class HtmlCodec implements ui.Codec {
-  HtmlCodec(this.src, {this.chunkCallback});
+abstract class HTMLImageElementCodec implements ui.Codec {


nit: I think the style guide prefers Html rather than HTML.

…ent renderers (flutter/engine#52905)

…148766) flutter/engine@c2ef01f...8a352f0 2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from c6bb2106c13b to e0881f06f94a (1 revision) (flutter/engine#52954) 2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from cb763e4dad50 to dd768e0d1890 (1 revision) (flutter/engine#52953) 2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 2102f791405c to c6bb2106c13b (1 revision) (flutter/engine#52952) 2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 1a52d4d5f45e to 2102f791405c (1 revision) (flutter/engine#52951) 2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 97d3b45d6b00 to 1a52d4d5f45e (1 revision) (flutter/engine#52947) 2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from d1a786ef6888 to cb763e4dad50 (1 revision) (flutter/engine#52950) 2024-05-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.13.4 to 3.25.6 (flutter/engine#52949) 2024-05-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.5 to 4.1.6 (flutter/engine#52948) 2024-05-21 skia-flutter-autoroll@skia.org Roll Skia from 62f369c75994 to 97d3b45d6b00 (1 revision) (flutter/engine#52946) 2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 01a77883e9e9 to d1a786ef6888 (1 revision) (flutter/engine#52945) 2024-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jXE7fqJI6VWFMaIdV... to HHwlAJN5imwf3yX4i... (flutter/engine#52944) 2024-05-21 bdero@google.com [Impeller] Reland: Remove Entity capture/AiksInspector. (flutter/engine#52932) 2024-05-20 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Refactor HtmlImageCodec to generalize to different renderers (flutter/engine#52905) 2024-05-20 skia-flutter-autoroll@skia.org Roll Skia from 977a43773f7c to 62f369c75994 (1 revision) (flutter/engine#52941) 2024-05-20 skia-flutter-autoroll@skia.org Roll Skia from 0b8d8ce44d1f to 977a43773f7c (1 revision) (flutter/engine#52938) 2024-05-20 jonahwilliams@google.com [Impeller] write glyphs to malloc buffer. (flutter/engine#52937) 2024-05-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 08f4324c988b to 01a77883e9e9 (1 revision) (flutter/engine#52936) 2024-05-20 bdero@google.com [Impeller] Fix use-after-move in SwapchainVK. (flutter/engine#52933) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from jXE7fqJI6VWF to HHwlAJN5imwf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

harryterkelsen added 3 commits May 17, 2024 09:11

Refactor HtmlImageCodec to be more general

a527a3f

Merge branch 'main' into image-decode-using-img

2fd2938

rename html_image_codec to html_image_element_codec

90a5c98

github-actions bot added the platform-web Code specifically for the web engine label May 17, 2024

update licenses

024e73b

harryterkelsen requested a review from yjbanov May 17, 2024 22:43

yjbanov approved these changes May 20, 2024

View reviewed changes

HTML -> Html

9569dac

harryterkelsen merged commit fd24d40 into flutter:main May 20, 2024
26 checks passed

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to fd24d4079168 (6 revisions) flutter/flutter#148729

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

d188e1c

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to ba84e44784cd (7 revisions) flutter/flutter#148731

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

92de15a

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 61b5fbf3827e (8 revisions) flutter/flutter#148734

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

596d0d3

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 64398fa8c638 (9 revisions) flutter/flutter#148736

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

a00ee07

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 3df7bae721cb (10 revisions) flutter/flutter#148740

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

cd9f278

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 7b1363ef9e1f (11 revisions) flutter/flutter#148744

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

816464b

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to b25c32d5c6e4 (12 revisions) flutter/flutter#148746

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

f2a2857

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to d5ef1aeed4e2 (14 revisions) flutter/flutter#148748

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

f2545c5

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 2f9a6908ed35 (15 revisions) flutter/flutter#148750

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

a5bb2eb

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 2f9a6908ed35 (15 revisions) flutter/flutter#148754

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

ce27667

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 2f9a6908ed35 (15 revisions) flutter/flutter#148758

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

6d5cfa3

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to b339ecbe1b9f (16 revisions) flutter/flutter#148759

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

fe13dbc

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 0b5d5a70dab9 (17 revisions) flutter/flutter#148764

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

0d8b477

…ent renderers (flutter/engine#52905)

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter Engine from c2ef01f6f1ab to 8a352f01e503 (18 revisions) flutter/flutter#148766

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2024

fd24d4079 [canvaskit] Refactor HtmlImageCodec to generalize to differ…

9324104

…ent renderers (flutter/engine#52905)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[canvaskit] Refactor HtmlImageCodec to generalize to different renderers #52905

[canvaskit] Refactor HtmlImageCodec to generalize to different renderers #52905

Uh oh!

harryterkelsen commented May 17, 2024

Uh oh!

yjbanov left a comment

Uh oh!

yjbanov May 20, 2024

Uh oh!

harryterkelsen May 20, 2024

Uh oh!

Uh oh!

Uh oh!

[canvaskit] Refactor HtmlImageCodec to generalize to different renderers #52905

[canvaskit] Refactor HtmlImageCodec to generalize to different renderers #52905

Uh oh!

Conversation

harryterkelsen commented May 17, 2024

Pre-launch Checklist

Uh oh!

yjbanov left a comment

Choose a reason for hiding this comment

Uh oh!

yjbanov May 20, 2024

Choose a reason for hiding this comment

Uh oh!

harryterkelsen May 20, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!