This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] ensure Path.close does not insert lineTo for stroked paths. #52171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…engine into fix_close_stroke_polyline
|
confusingly this breaks some other cases where we rely on the final lineTo |
|
OKAY I got it. THe problem is that the code in question has a moveTo followed by a close, which inserts two contours. moveTo implicitly closes. close has a check for continuous contours but it might not be working in this case. I think that narrows it down and the bug is more specific. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
|
Closing in favor of #52290 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#146648
We shouldn't insert a LineTo to the path start when drawing a stroke. The convex tessellation currently relies on this, but I plan to refactor this later so we don't depend on this point.