Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Reduce log level of unsupported accessibility event message #51024

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

loic-sharma
Copy link
Member

#50975 made the Windows embedder a bit more defensive on accessibility event messages and introduced an error if it received an event it does not support. This change reduces that error to a warning as it can be triggered by hovering over the counter app's + button.

Fixes flutter/flutter#144274

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2024
@auto-submit auto-submit bot merged commit d6bca2a into flutter:main Feb 28, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 28, 2024
8acc96d405 Roll Dart SDK from 1e6b559fae88 to 44af84628b90 (1 revision) (flutter/engine#51035)
632f9d742d Roll Skia from 84c60d70fbbd to a673ab63fccc (1 revision) (flutter/engine#51034)
5c09604bd6 Null-assert the value given to a Completer expecting a non-null value (flutter/engine#49053)
055ede728c Roll Dart SDK from a0e3c16eea3e to 1e6b559fae88 (1 revision) (flutter/engine#51025)
d6bca2a382 [Windows] Reduce log level of unsupported accessibility event message (flutter/engine#51024)
8fa1141b46 Roll Skia from c8703c91675e to 84c60d70fbbd (4 revisions) (flutter/engine#51021)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Counter app logs error when hovering over the + button
2 participants