This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Introduce an accessibility plugin #50975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
loic-sharma
commented
Feb 26, 2024
| const auto* message = std::get_if<std::string>(&message_itr->second); | ||
| if (!message) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
@yaakovschectman following up on this conversation: #50898 (comment)
I added error logs for malformed top-level type and data properties. I kept the plugin "flexible" on the announcement message's inner message data property, similar to other embedders' logic.
yaakovschectman
approved these changes
Feb 26, 2024
loic-sharma
added
the
autosubmit
This was referenced Feb 27, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
…#51024) #50975 made the Windows embedder a bit more defensive on accessibility event messages and introduced an error if it received an event it does not support. This change reduces that error to a warning as it can be triggered by hovering over the counter app's `+` button. Fixes flutter/flutter#144274 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
c79117b706 [Windows] Remove TODONE (flutter/engine#51005) 24c7b03ef0 [Windows] Introduce an accessibility plugin (flutter/engine#50975) c805e43957 Roll Skia from 1beae57ea0dd to c8703c91675e (1 revision) (flutter/engine#51014) 17dff87ef3 [Impeller] various StC fixes for GPU -> CPU readback plus BufferBindingGLES error (flutter/engine#50951) 8457d10473 Roll Dart SDK from be6be2b9ba6e to a0e3c16eea3e (3 revisions) (flutter/engine#51015)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same pull request as #50898. GitHub broke on the previous pull request so I re-created it
This moves the logic to handle
flutter/accessibilitymessages to a new type,AccessibilityPlugin.Notable changes:
@yaakovschectman After playing around with this, I ended up using a different pattern than what what I suggested on #50598 (comment). This message handler is simple enough that splitting into a child/base types felt like unnecessary boilerplate. The key thing is separating messaging and implementation logic, which was achieved through the
SetUpmethod. Let me know what you think, and sorry for all my flip-flopping on this topic! 😅This is preparation for: flutter/flutter#143765
Sample app for manual testing: flutter/flutter#113059
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.