This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Disallow files additional named GeneratedPluginRegistrant.java
.
#50796
Merged
auto-submit
merged 10 commits into
flutter:main
from
matanlurey:fake-generated-plugin-registrant
Feb 21, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5a2a092
Rename and disallow files named .
matanlurey d8b4a0f
Revert.
matanlurey 7504d17
Revert.
matanlurey cdf98d2
Add test on CI.
matanlurey 2f7e2de
++
matanlurey 4c34c37
++
matanlurey 293a55e
++
matanlurey 4b8e403
++
matanlurey e9d6c2a
++
matanlurey 98203e6
++
matanlurey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
#!/bin/bash | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this script have the execute bit set? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, I just typed it wrong in the CI configuration. PTAL. |
||
# | ||
# Copyright 2013 The Flutter Authors. All rights reserved. | ||
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
set -e | ||
|
||
# Needed because if it is set, cd may print the path it changed to. | ||
unset CDPATH | ||
|
||
# On Mac OS, readlink -f doesn't work, so follow_links traverses the path one | ||
# link at a time, and then cds into the link destination and find out where it | ||
# ends up. | ||
# | ||
# The function is enclosed in a subshell to avoid changing the working directory | ||
# of the caller. | ||
function follow_links() ( | ||
cd -P "$(dirname -- "$1")" | ||
file="$PWD/$(basename -- "$1")" | ||
while [[ -h "$file" ]]; do | ||
cd -P "$(dirname -- "$file")" | ||
file="$(readlink -- "$file")" | ||
cd -P "$(dirname -- "$file")" | ||
file="$PWD/$(basename -- "$file")" | ||
done | ||
echo "$file" | ||
) | ||
|
||
SCRIPT_DIR=$(follow_links "$(dirname -- "${BASH_SOURCE[0]}")") | ||
SRC_DIR="$( | ||
cd "$SCRIPT_DIR/../../.." | ||
pwd -P | ||
)" | ||
FLUTTER_DIR="$SRC_DIR/flutter" | ||
|
||
# Creates a file named `GeneratedPluginRegistrant.java` in the project outside | ||
# of it's expected location in shell/platform/android/test/... (where the exact | ||
# name and location is required to get loaded). | ||
# | ||
# This file is typically generated by Flutter tooling and should not exist. | ||
touch "$FLUTTER_DIR/GeneratedPluginRegistrant.java" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Optional: Consider putting this in a subdirectory given that this file would likely be deeper in the file tree. |
||
|
||
# Create a trap that, on exit, removes the file. | ||
function cleanup() { | ||
rm -f "$FLUTTER_DIR/GeneratedPluginRegistrant.java" | ||
} | ||
trap cleanup EXIT | ||
|
||
# Runs ../format.sh and verifies that it fails with the expected error message. | ||
# If it fails, the script prints an error message and exits with a non-zero status. | ||
"$FLUTTER_DIR/ci/format.sh" || { | ||
echo "PASS: analyze.sh failed as expected" | ||
exit 0 | ||
} | ||
|
||
echo "FAIL: format.sh did not fail as expected" | ||
exit 1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That configuration causes this test to run in ci?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVM, you added it in ci/builders/linux_unopt.json