Disallow files additional named GeneratedPluginRegistrant.java.
#50796
Conversation
ci/format.sh
Outdated
| @@ -18,7 +18,7 @@ unset CDPATH | |||
| function follow_links() ( | |||
| cd -P "$(dirname -- "$1")" | |||
| file="$PWD/$(basename -- "$1")" | |||
| while [[ -h "$file" ]]; do | |||
| while [[ -L "$file" ]]; do | |||
There was a problem hiding this comment.
Consider adding a comment explaining what -L "$file" means.
There was a problem hiding this comment.
I just reverted it, that was a mistake.
|
|
||
| # Creates a file named `GeneratedPluginRegistrant.java` in the project. | ||
| # This file is generated by Flutter tooling and should not be checked in. | ||
| touch "$FLUTTER_DIR/GeneratedPluginRegistrant.java" |
There was a problem hiding this comment.
Optional: Consider putting this in a subdirectory given that this file would likely be deeper in the file tree.
| @@ -0,0 +1,55 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
That configuration causes this test to run in ci?
There was a problem hiding this comment.
NVM, you added it in ci/builders/linux_unopt.json
ci/format.sh
Outdated
| GENERATED_PLUGIN_REGISTRANT_PATH=$(find "$SRC_DIR/flutter" -name "GeneratedPluginRegistrant.java") | ||
| if [[ -n "$GENERATED_PLUGIN_REGISTRANT_PATH" ]]; then | ||
| echo "GeneratedPluginRegistrant.java found in the project." | ||
| echo "This file is generated by Flutter tooling and should not be checked in." |
There was a problem hiding this comment.
It's not just that it shouldn't be checked in, it should be present at all right?
There was a problem hiding this comment.
Yeah better, changed!
I already sent you #50795 😅 |
| @@ -0,0 +1,55 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Does this script have the execute bit set?
There was a problem hiding this comment.
Yup, I just typed it wrong in the CI configuration. PTAL.
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/50796, due to - The status or check suite Linux linux_android_debug_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
matanlurey
changed the title
GeneratedPluginRegistrant.java.GeneratedPluginRegistrant.java.
reidbaker
added
the
autosubmit
…143856) flutter/engine@e16f43e...4128895 2024-02-21 matanlurey@users.noreply.github.com Disallow files additional named `GeneratedPluginRegistrant.java`. (flutter/engine#50796) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closes flutter/flutter#143782.
Also introduces a test that the test itself passes.
I considered adding this to
ci/analyze.sh, but it seems better suited forci/format.sh(which is also on git-hooks). Wdut?