This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[web] Ensure handled key event is not propagated to IME" #47086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit d3c97bb.
dkwingsmt
approved these changes
Oct 19, 2023
Member
|
The integration test is creating keyboard event with |
knopp
deleted the
revert-46829-136460_web_no_propagate_handled_event_to_ime
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 19, 2023
…136872) flutter/engine@8d51b64...d0d7b4d 2023-10-19 flar@google.com Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086) 2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094) 2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 64c5de6663a4 to 62acc1e162cc (1 revision) (flutter/engine#47093) 2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from eb3fb9a13e16 to 1b425a25a6dd (1 revision) (flutter/engine#47092) 2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 85971b25cf4b to 64c5de6663a4 (2 revisions) (flutter/engine#47091) 2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PxJM5ivbnbYoVkqBg... to 0hLSNJ_DCTzRvTVJe... (flutter/engine#47090) 2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from d9b1e60fe442 to eb3fb9a13e16 (1 revision) (flutter/engine#47084) 2023-10-18 chinmaygarde@google.com Update buildroot to ab76ccba2ca4ce4. (flutter/engine#47078) 2023-10-18 fujino@google.com migrate const_finder to use the implementation from package:kernel (flutter/engine#47077) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d561b276b5d9 to 85971b25cf4b (1 revision) (flutter/engine#47076) 2023-10-18 jason-simmons@users.noreply.github.com [Impeller] Guard execution of ReactorGLES operations with a mutex (flutter/engine#47068) 2023-10-18 chinmaygarde@google.com [Impeller] Document ReactorGLES. (flutter/engine#47070) 2023-10-18 matej.knopp@gmail.com [web] Ensure handled key event is not propagated to IME (flutter/engine#46829) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 2HSBpWikGWvP to Z2mOZ5cuPJWv fuchsia/sdk/core/mac-amd64 from PxJM5ivbnbYo to 0hLSNJ_DCTzR If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
) Reverts #46829 Fixes flutter/flutter#136857 Speculative fix for The builds breaking on the web text tests as seen here: https://github.com/flutter/flutter/runs/17840697842
knopp
added a commit
that referenced
this pull request
Nov 3, 2023
This PR relands #46829, which got reverted in #47086 because of flutter/flutter#136857. There are no changes in the PR compared to the reverted one. The issue are missing `keyup` events in the integration test, which triggers assertion in `KeyboardBindings` and which should be fixed by flutter/flutter#136874. Changes: - Raw keyboard event is handled during capture phase. This is to ensure that the framework processes the event before reaching to IME text area and raw keyboard can stop the propagation for handled events. - `RawKeyboard` event handler is invoked from `KeyboardBinding` event handler. This is to prevent race condition because both handlers now run in capture phase and `KeyboardBinding` needs to process the event first. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #46829
Fixes flutter/flutter#136857
Speculative fix for The builds breaking on the web text tests as seen here: https://github.com/flutter/flutter/runs/17840697842