This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Guard execution of ReactorGLES operations with a mutex #47068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| op(*this); | ||
| // Both the raster thread and the IO thread can flush queued operations. | ||
| // Ensure that execution of the ops is serialized. | ||
| Lock execution_lock(ops_execution_mutex_); |
Member
There was a problem hiding this comment.
I think a better place for this guard would be around ReactOnce. You can place IPLR_REQUIRES around ReactOnce to give you static analysis too so its harder to mess up in the future.
Both the raster and IO threads can flush the ops queue. The reactor must ensure that execution of queued ops is serialized. Fixes flutter/flutter#135524
jason-simmons
force-pushed
the
bug_135524
branch
from
4897dca to
9954808
Compare
chinmaygarde
approved these changes
Oct 18, 2023
Member
|
Thanks. I documented ReactorGLES in #47070 just so the usage is clearer. |
Member
|
I don't think the framework smoke tests are related to this. Going to retry. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 19, 2023
…136872) flutter/engine@8d51b64...d0d7b4d 2023-10-19 flar@google.com Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086) 2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094) 2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 64c5de6663a4 to 62acc1e162cc (1 revision) (flutter/engine#47093) 2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from eb3fb9a13e16 to 1b425a25a6dd (1 revision) (flutter/engine#47092) 2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 85971b25cf4b to 64c5de6663a4 (2 revisions) (flutter/engine#47091) 2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PxJM5ivbnbYoVkqBg... to 0hLSNJ_DCTzRvTVJe... (flutter/engine#47090) 2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from d9b1e60fe442 to eb3fb9a13e16 (1 revision) (flutter/engine#47084) 2023-10-18 chinmaygarde@google.com Update buildroot to ab76ccba2ca4ce4. (flutter/engine#47078) 2023-10-18 fujino@google.com migrate const_finder to use the implementation from package:kernel (flutter/engine#47077) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d561b276b5d9 to 85971b25cf4b (1 revision) (flutter/engine#47076) 2023-10-18 jason-simmons@users.noreply.github.com [Impeller] Guard execution of ReactorGLES operations with a mutex (flutter/engine#47068) 2023-10-18 chinmaygarde@google.com [Impeller] Document ReactorGLES. (flutter/engine#47070) 2023-10-18 matej.knopp@gmail.com [web] Ensure handled key event is not propagated to IME (flutter/engine#46829) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 2HSBpWikGWvP to Z2mOZ5cuPJWv fuchsia/sdk/core/mac-amd64 from PxJM5ivbnbYo to 0hLSNJ_DCTzR If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
…7068) Both the raster and IO threads can flush the ops queue. The reactor must ensure that execution of queued ops is serialized. Fixes flutter/flutter#135524
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the raster and IO threads can flush the ops queue. The reactor must ensure that execution of queued ops is serialized.
Fixes flutter/flutter#135524