Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add a way to query the gfx backend type. #43837

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Jul 19, 2023

I've been trying to avoid this, but since the context type may vary through runtime decisions, we just need something like this to select which shader data to pull from the Dart GPU bundle at runtime. One alternative would be to add a special omni shader concept to the HAL, but that seems worse than just letting renderers key with a backend enum sometimes.

Cautioned against using it for cap checks in the doc string.

@bdero bdero self-assigned this Jul 19, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bdero bdero requested a review from chinmaygarde July 19, 2023 23:24
@bdero bdero force-pushed the bdero/context-backend-type branch from e08c502 to cf9d745 Compare July 19, 2023 23:26
@chinmaygarde
Copy link
Member

The test failures are real. The mock needs to be updated to account for the new API.

@bdero bdero force-pushed the bdero/context-backend-type branch from cf9d745 to cdc6877 Compare July 20, 2023 21:18
@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 20, 2023

auto label is removed for flutter/engine, pr: 43837, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bdero bdero force-pushed the bdero/context-backend-type branch from cdc6877 to 35cdd66 Compare July 21, 2023 17:40
@bdero bdero force-pushed the bdero/context-backend-type branch from 35cdd66 to 60b8343 Compare July 21, 2023 18:03
@bdero bdero merged commit 3e8c7a9 into flutter:main Jul 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 22, 2023
…131101)

flutter/engine@2d8cff4...840bcc3

2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907)
2023-07-21 jason-simmons@users.noreply.github.com [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
2023-07-21 bdero@google.com [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
2023-07-21 bdero@google.com [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
…lutter#131101)

flutter/engine@2d8cff4...840bcc3

2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907)
2023-07-21 jason-simmons@users.noreply.github.com [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
2023-07-21 bdero@google.com [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
2023-07-21 bdero@google.com [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
…lutter#131101)

flutter/engine@2d8cff4...840bcc3

2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907)
2023-07-21 jason-simmons@users.noreply.github.com [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
2023-07-21 bdero@google.com [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
2023-07-21 bdero@google.com [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants