Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Disable color attachment removal for clips on VK #43905

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[Impeller] Disable color attachment removal for clips on VK #43905

merged 1 commit into from
Jul 21, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Jul 21, 2023

This is causing a validation failure on the Vulkan backend at ToT, as discovered by @jonahwilliams.

Need to figure out why this isn't getting hit in the Vulkan goldens.

@bdero bdero requested a review from jonahwilliams July 21, 2023 19:43
@bdero bdero self-assigned this Jul 21, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jonahwilliams
jonahwilliams approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2023
@bdero bdero mentioned this pull request Jul 21, 2023
Closed
@auto-submit auto-submit bot merged commit bcda9a5 into flutter:main Jul 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2023
@engine-flutter-autoroll
bcda9a50d [Impeller] Disable color attachment removal for clips on VK (…
0615066 
…flutter/engine#43905)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jul 22, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 2d8cff44261b to 840bcc3449ff (11 revisions) (#…
3e67e19 
…131101)

flutter/engine@2d8cff4...840bcc3

2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907)
2023-07-21 jason-simmons@users.noreply.github.com [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
2023-07-21 bdero@google.com [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
2023-07-21 bdero@google.com [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero added a commit to bdero/flutter-engine that referenced this pull request Jul 24, 2023
@bdero
Revert "[Impeller] Disable color attachment removal for clips on VK (f…
c249e56 
…lutter#43905)"

This reverts commit bcda9a5.
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Flutter Engine from 2d8cff44261b to 840bcc3449ff (11 revisions) (f…
c06aee3 
…lutter#131101)

flutter/engine@2d8cff4...840bcc3

2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907)
2023-07-21 jason-simmons@users.noreply.github.com [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
2023-07-21 bdero@google.com [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
2023-07-21 bdero@google.com [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@engine-flutter-autoroll @vashworth
Roll Flutter Engine from 2d8cff44261b to 840bcc3449ff (11 revisions) (f…
2073238 
…lutter#131101)

flutter/engine@2d8cff4...840bcc3

2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907)
2023-07-21 jason-simmons@users.noreply.github.com [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
2023-07-21 bdero@google.com [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
2023-07-21 bdero@google.com [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@bdero bdero

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdero @jonahwilliams