This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Treat SubOptimalKHR as rotated. #43214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
I filed flutter/flutter#129580 to followup. But LGTM otherwise.
chinmaygarde
changed the title
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 26, 2023
…129593) flutter/engine@0da06de...715eff2 2023-06-26 58529443+srujzs@users.noreply.github.com Refactor JSNumber.toDart and Object.toJS (flutter/engine#43149) 2023-06-26 jonahwilliams@google.com [Impeller] Treat SubOptimalKHR as rotated. (flutter/engine#43214) 2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from f6c7dc891859 to 4a4b13cc6931 (12 revisions) (flutter/engine#43213) 2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 632fa401098d to 4ae209493390 (3 revisions) (flutter/engine#43212) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
If we don't follow the guidelines at https://developer.android.com/games/optimize/vulkan-prerotation , then any presentations while the screen is rotated will result in suboptimalKHR. Use a change in state across presentations from sucess -> suboptimal or suboptimal -> sucess to detect whether the swapchain needs to be recreated. Fixes flutter/flutter#129459 (mostly)
matanlurey
added a commit
to matanlurey/engine
that referenced
this pull request
Aug 3, 2023
This reverts commit e32f60a.
matanlurey
added a commit
that referenced
this pull request
Aug 10, 2023
tl;dr: Reverts #43214. closes flutter/flutter#129459.  --- In #43214, @jonahwilliams used `vkQueuePresentKHR`[^1] [to check](https://github.com/jonahwilliams/engine/blob/a0df46add166202fe68a853391d379e69ddc7c18/impeller/renderer/backend/vulkan/swapchain_impl_vk.cc#L465-L467) if device orientations had changed, and if so, the swap-chain was torn down and replaced with a new instance (that would now have a correct rotation for ... compositing reasons I don't quite understand). Unfortunately `vkQueuePresentKHR` is (a) only present on Android 10+ _and_ (b) ... isn't implemented consistently across Android devices. For example, the popular Samsung Galaxy S10 doesn't return `VK_SUBOPTIMAL_KHR`, leading to the same rotation bugs described in flutter/flutter#129459 (i.e. even with #43214). This PR implements the polling technique recommended by Android[^2], in this case on every frame. We should expect this to have a performance penalty of ~`0.2`ms per frame, but should at least give us consistent fidelity on Vulkan + Android for the time-being.  <details> <summary> Some additional screenshots generated while debugging </summary> <img src ="https://github.com/flutter/engine/assets/168174/900e02a8-aa51-4592-9690-c650092130a2" /> <img src="https://github.com/flutter/engine/assets/168174/e7b9e5c0-86b0-407f-aa51-2f76afda4f03)" /> <img src="https://github.com/flutter/engine/assets/168174/6b611090-97f5-4589-9ef9-6ba778efc6b7" /> </details> [^1]: https://developer.android.com/games/optimize/vulkan-prerotation#detect_device_orientation_changes [^2]: https://developer.android.com/games/optimize/vulkan-prerotation#using_polling
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
tl;dr: Reverts flutter#43214. closes flutter/flutter#129459.  --- In flutter#43214, @jonahwilliams used `vkQueuePresentKHR`[^1] [to check](https://github.com/jonahwilliams/engine/blob/a0df46add166202fe68a853391d379e69ddc7c18/impeller/renderer/backend/vulkan/swapchain_impl_vk.cc#L465-L467) if device orientations had changed, and if so, the swap-chain was torn down and replaced with a new instance (that would now have a correct rotation for ... compositing reasons I don't quite understand). Unfortunately `vkQueuePresentKHR` is (a) only present on Android 10+ _and_ (b) ... isn't implemented consistently across Android devices. For example, the popular Samsung Galaxy S10 doesn't return `VK_SUBOPTIMAL_KHR`, leading to the same rotation bugs described in flutter/flutter#129459 (i.e. even with flutter#43214). This PR implements the polling technique recommended by Android[^2], in this case on every frame. We should expect this to have a performance penalty of ~`0.2`ms per frame, but should at least give us consistent fidelity on Vulkan + Android for the time-being.  <details> <summary> Some additional screenshots generated while debugging </summary> <img src ="https://github.com/flutter/engine/assets/168174/900e02a8-aa51-4592-9690-c650092130a2" /> <img src="https://github.com/flutter/engine/assets/168174/e7b9e5c0-86b0-407f-aa51-2f76afda4f03)" /> <img src="https://github.com/flutter/engine/assets/168174/6b611090-97f5-4589-9ef9-6ba778efc6b7" /> </details> [^1]: https://developer.android.com/games/optimize/vulkan-prerotation#detect_device_orientation_changes [^2]: https://developer.android.com/games/optimize/vulkan-prerotation#using_polling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't follow the guidelines at https://developer.android.com/games/optimize/vulkan-prerotation , then any presentations while the screen is rotated will result in suboptimalKHR. Use a change in state across presentations from sucess -> suboptimal or suboptimal -> sucess to detect whether the swapchain needs to be recreated.
Fixes flutter/flutter#129459 (mostly)