Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0da06de991a9
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 715eff211a42
Choose a head ref
  • 4 commits
  • 16 files changed
  • 3 contributors

Commits on Jun 26, 2023

  1. Roll Skia from 632fa401098d to 4ae209493390 (3 revisions) (#43212) 

    https://skia.googlesource.com/skia.git/+log/632fa401098d..4ae209493390

2023-06-26 brianosman@google.com Suppress divide-by-zero errors in cubic-to-quads code
2023-06-26 brianosman@google.com Suppress divide-by-zero error in SkContourMeasureIter construction
2023-06-26 nicolettep@google.com Manual roll Dawn from 8278361fbbef to cadd0c0eec3f (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f138c57 View commit details
    Browse the repository at this point in the history

  2. Roll ANGLE from f6c7dc891859 to 4a4b13cc6931 (12 revisions) (#43213) 

    https://chromium.googlesource.com/angle/angle.git/+log/f6c7dc891859..4a4b13cc6931

2023-06-26 romanl@google.com Fix SixteenBppTextureDitheringTestES3 formats
2023-06-26 yuxinhu@google.com Update the mustpass list that dEQP-EGL tests uses
2023-06-26 syoussefi@chromium.org Move state dirty bits definitions out of the class
2023-06-26 m.maiya@samsung.com Refactor Image colorspace tests for better readability
2023-06-26 m.maiya@samsung.com Reset and then populate frontend features during display initialize
2023-06-26 syoussefi@chromium.org Vulkan: Remove ShaderVariableType and flatten info map
2023-06-26 steven@uplinklabs.net D3D11: identify D3D11on12 in renderer string
2023-06-26 syoussefi@chromium.org Vulkan: Simplify shader interface variable map
2023-06-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from f29bd2feeaff to 12bc45af35d5 (10 revisions)
2023-06-26 steven@uplinklabs.net remove ScheduleYield, replace with std::this_thread::yield
2023-06-26 steven@uplinklabs.net Vulkan: fix blob caching of initial pipeline cache
2023-06-26 amy@amyspark.me CLRefPointer: fix reference to STL type for MinGW Clang

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f128827 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Treat SubOptimalKHR as rotated. (#43214) 

    If we don't follow the guidelines at https://developer.android.com/games/optimize/vulkan-prerotation , then any presentations while the screen is rotated will result in suboptimalKHR. Use a change in state across presentations from sucess -> suboptimal or suboptimal -> sucess to detect whether the swapchain needs to be recreated.

Fixes flutter/flutter#129459 (mostly)
    Jonah Williams authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e32f60a View commit details
    Browse the repository at this point in the history

  4. Refactor JSNumber.toDart and Object.toJS (#43149) 

    JSNumber.toDart will now be two functions: toDartDouble and toDartInt.
Note that some code that looks like `toDart.toInt()` was kept as
`toDartDouble.toInt()` instead of `toDartInt`, since `toDartInt` throws
if the value is not an integer.

Object.toJS is now Object.toJSBox. An actual box is introduced on all
backends now, and is unwrapped in JSBoxedDartObject.toDart. There are
many usages of toJSAnyShallow that we should modify, but that's for a
later CL.

This is to help land this CL:
https://dart-review.googlesource.com/c/sdk/+/309082

https://dart-review.googlesource.com/c/sdk/+/309081 is the CL that added
the new methods.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
    @srujzs
    srujzs authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    715eff2 View commit details
    Browse the repository at this point in the history
Loading