Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Do not run mac unit tests on macmini7,1 #41203

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Do not run mac unit tests on macmini7,1 #41203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ targets:
{"download_emsdk": true}
add_recipes_cq: "true"
build_host: "true"
mac_model: "Macmini8,1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to go into the json files where we specify the dimensions. Does this work?

Copy link
Contributor

@CaseyHillers CaseyHillers Apr 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/model/ci_yaml/target.dart;l=40

This does get run, but it'll only change the orchestrator vm. This is useful as the spawned tasks should inherit the dimensions from the orchestrator.

timeout: 75

- name: Mac mac_android_aot_engine
Expand Down Expand Up @@ -377,6 +378,7 @@ targets:
[
"ios-16-0_14a5294e"
]
mac_model: "Macmini8,1"
timeout: 75

- name: Mac Host clang-tidy
Expand Down