This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not run mac unit tests on macmini7,1 #41203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
changed the title
|
Mac Host Engine on #41194 has failed 3 or 4 times in impeller_unittests on the 5100 GPU. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
dnfield
reviewed
Apr 14, 2023
| @@ -338,6 +338,7 @@ targets: | |||
| {"download_emsdk": true} | |||
| add_recipes_cq: "true" | |||
| build_host: "true" | |||
| mac_model: "Macmini8,1" | |||
There was a problem hiding this comment.
I think this has to go into the json files where we specify the dimensions. Does this work?
There was a problem hiding this comment.
https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/model/ci_yaml/target.dart;l=40
This does get run, but it'll only change the orchestrator vm. This is useful as the spawned tasks should inherit the dimensions from the orchestrator.
dnfield
approved these changes
Apr 14, 2023
CaseyHillers
approved these changes
Apr 14, 2023
|
Filed flutter/flutter#124877 - once that lands we should rever tthis and the other PRs I made to try to avoid using mac 7,1 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 14, 2023
…124886) flutter/engine@87fc464...9c31406 2023-04-14 zanderso@users.noreply.github.com Run the Mac impeller-cmake-example orchestrator on arm64 (flutter/engine#41194) 2023-04-14 chinmaygarde@google.com Fix warning about angle_build_all being unread on Mac builds. (flutter/engine#41176) 2023-04-14 magder@google.com Change v2 `mac_android_aot_engine` orchestrator builder to Linux (flutter/engine#41181) 2023-04-14 zanderso@users.noreply.github.com Do not run mac unit tests on macmini7,1 (flutter/engine#41203) 2023-04-14 skia-flutter-autoroll@skia.org Manual roll Skia from ad2e21650306 to 2bd12e31d578 (14 revisions) (flutter/engine#41206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…lutter#124886) flutter/engine@87fc464...9c31406 2023-04-14 zanderso@users.noreply.github.com Run the Mac impeller-cmake-example orchestrator on arm64 (flutter/engine#41194) 2023-04-14 chinmaygarde@google.com Fix warning about angle_build_all being unread on Mac builds. (flutter/engine#41176) 2023-04-14 magder@google.com Change v2 `mac_android_aot_engine` orchestrator builder to Linux (flutter/engine#41181) 2023-04-14 zanderso@users.noreply.github.com Do not run mac unit tests on macmini7,1 (flutter/engine#41203) 2023-04-14 skia-flutter-autoroll@skia.org Manual roll Skia from ad2e21650306 to 2bd12e31d578 (14 revisions) (flutter/engine#41206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impeller tests are hanging on Intel Haswell Iris Graphics 5100 (8086:0a2e)