`ui_web` library #40608

eyebrowsoffire · 2023-03-24T20:19:07Z

This introduces a public ui_web library that contains web-specific flutter APIs. The first thing to incorporate into this is UrlStrategy, which will allow us to replace a lot of the magic JS interop handshaking between framework and engine into a formalized API.

mdebbar

LGTM!

I don't have strong opinions on the library name, so I'll save you the bikeshedding from my end :)

mdebbar · 2023-03-24T20:21:16Z

lib/web_ui/lib/src/engine/navigation/history.dart

@@ -4,18 +4,18 @@

 import 'package:meta/meta.dart';
 import 'package:ui/ui.dart' as ui;
+import '../../../ui_web/src/ui_web.dart' as ui_web;


How hard would it be to make this similar to the package:ui/ui.dart above? (i.e. package:ui_web/ui_web.dart or something like that). I guess it's just a matter of rewriting it in the sdk_rewriter?

This just gets erased by the rewriter, and in the top-level library file it says import 'dart:ui_web' as ui_web; so for the original source files we can import it any way we like as long as it is imported under the name ui_web. I can try to find a cleaner way to do this import.

On second look, I think package:ui/src/ui_web.dart should work already?

lib/web_ui/lib/src/engine/navigation/history.dart

mdebbar · 2023-03-24T20:25:46Z

lib/web_ui/lib/src/engine/navigation/history.dart

@@ -183,15 +183,15 @@ class MultiEntriesBrowserHistory extends BrowserHistory {
  }

  @override
-  void onPopState(covariant DomPopStateEvent event) {
+  void onPopState(covariant DomPopStateEvent state) {


Can we keep it the name event or make it Object? state?

I have a feeling you were trying to change DomPopStateEvent event ==> Object? state but forgot to finish the change, or reverted it partially.

Hmmm... you're right, I kind of did a half-measure here. I think I can clean this up a bit.

So what I ended up doing here is to basically unwrap the JS event in JSUrlStrategy before it actually gets to the darty UrlStrategy object, and so the pop state listener just takes the state itself. I think this is a bit better. For stuff on the framework side that uses actual JS interop to do the pop listener thing, they can just unwrap it there as well. The path through JSUrlStrategy remains unchanged, so I think this is non-breaking for the framework (but I'll find out as soon as I start testing against the framework side).

lib/web_ui/lib/ui_web/src/ui_web.dart

web_sdk/BUILD.gn

lib/web_ui/lib/src/engine/navigation/url_strategy.dart

Co-authored-by: Mouad Debbar <mdebbar@google.com>

lib/web_ui/lib/src/engine/navigation/url_strategy.dart

yjbanov

kevmoo · 2023-03-27T21:55:43Z

lib/web_ui/lib/ui_web/src/ui_web.dart

+// found in the LICENSE file.
+
+/// This library defines the web-specific additions that go along with dart:ui
+library ui_web;


Suggested change

library ui_web;

library;

We now support name-less libraries.

I definitely don't want a nameless library though. This is a library that the framework (and maybe eventually users) will use by name.

The name will map to the file name, though. tis fine

See also: #40669

The sdk_rewriter will not be able to rewrite this file properly without this statement.

kevmoo · 2023-03-27T23:32:58Z

That's okay. I don't think it's a huge deal

…

On Mon, Mar 27, 2023, 16:17 Jackson Gardner ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/web_ui/lib/ui_web/src/ui_web.dart <#40608 (comment)>: > @@ -0,0 +1,8 @@ +// Copyright 2013 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +/// This library defines the web-specific additions that go along with dart:ui +library ui_web; The sdk_rewriter will not be able to rewrite this file properly without this statement. — Reply to this email directly, view it on GitHub <#40608 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEFCSAHDKEFF7EJGLTICLW6IN2FANCNFSM6AAAAAAWG73EVA> . You are receiving this because you commented.Message ID: ***@***.***>

eyebrowsoffire · 2023-03-28T20:53:16Z

I'm going to wait until after the branch cut to merge this.

…123833) flutter/engine@571c5de...c0e7cd5 2023-03-31 bdero@google.com [Impeller] iOS/macOS: Only wait for command scheduling prior to present (flutter/engine#40781) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 9b2e538f1367 to f6c1eefd4600 (4 revisions) (flutter/engine#40807) 2023-03-30 dnfield@google.com Revert "[Impeller] move everything needed by the code gen template to core (#40801)" (flutter/engine#40811) 2023-03-30 dnfield@google.com [Impeller] Delete dead code from reflector.cc (flutter/engine#40805) 2023-03-30 dnfield@google.com [Impeller] move everything needed by the code gen template to core (flutter/engine#40801) 2023-03-30 jacksongardner@google.com `ui_web` library (flutter/engine#40608) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#123833) flutter/engine@571c5de...c0e7cd5 2023-03-31 bdero@google.com [Impeller] iOS/macOS: Only wait for command scheduling prior to present (flutter/engine#40781) 2023-03-31 skia-flutter-autoroll@skia.org Roll Skia from 9b2e538f1367 to f6c1eefd4600 (4 revisions) (flutter/engine#40807) 2023-03-30 dnfield@google.com Revert "[Impeller] move everything needed by the code gen template to core (flutter#40801)" (flutter/engine#40811) 2023-03-30 dnfield@google.com [Impeller] Delete dead code from reflector.cc (flutter/engine#40805) 2023-03-30 dnfield@google.com [Impeller] move everything needed by the code gen template to core (flutter/engine#40801) 2023-03-30 jacksongardner@google.com `ui_web` library (flutter/engine#40608) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This is based off (and dependent on) these changes in the web engine that expose web-specific APIs: flutter/engine#40608

eyebrowsoffire added 2 commits March 23, 2023 15:20

Started making ui_web

8801c1e

Create a ui_web library with UrlStrategy in it.

7b6339d

flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 24, 2023

mdebbar reviewed Mar 24, 2023

View reviewed changes

eyebrowsoffire and others added 4 commits March 24, 2023 14:20

Update lib/web_ui/lib/ui_web/src/ui_web.dart

4500675

Co-authored-by: Mouad Debbar <mdebbar@google.com>

Strip the state out of the JS event before passing it to the dart API.

b6ee664

Fix sdk_rewriter_test

7cfaeb8

Clean up import path.

079b36e

mdebbar reviewed Mar 24, 2023

View reviewed changes

lib/web_ui/lib/src/engine/navigation/url_strategy.dart Show resolved Hide resolved

eyebrowsoffire added 4 commits March 24, 2023 15:29

allowInterop on the pop listener going into the JSUrlStrategy

1efd5c1

Update HashUrlStrategy too.

75a0440

Get out of there dart:html

6389f65

Some more tweaks to match the framework's definition.

5234e9d

yjbanov approved these changes Mar 25, 2023

View reviewed changes

eyebrowsoffire added 4 commits March 27, 2023 11:36

Unwrap the tagged state object.

32f2339

Merge branch 'main' into web_ui_library

8d5f22e

Merge branch 'main' into web_ui_library

502833e

Merge branch 'main' into web_ui_library

20b57dd

kevmoo reviewed Mar 27, 2023

View reviewed changes

Merge branch 'main' into web_ui_library

43b2765

eyebrowsoffire mentioned this pull request Mar 28, 2023

Use direct dart API from dart:ui_web rather than JS shim. flutter/flutter#123443

Merged

eyebrowsoffire added 2 commits March 28, 2023 13:51

Merge branch 'main' into web_ui_library

afa4245

Keep library directive with a comment.

b228ebf

eyebrowsoffire marked this pull request as ready for review March 29, 2023 16:24

eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023

auto-submit bot merged commit a6deb36 into main Mar 30, 2023

auto-submit bot deleted the web_ui_library branch March 30, 2023 23:14

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter Engine from 571c5defaa18 to c0e7cd5237c3 (6 revisions) flutter/flutter#123833

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2023

a6deb3676 ui_web library (flutter/engine#40608)

84b4e90

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 5, 2023

Use direct dart API from dart:ui_web rather than JS shim. (#123443)

201f731

This is based off (and dependent on) these changes in the web engine that expose web-specific APIs: flutter/engine#40608

ztaylor54 mentioned this pull request Feb 19, 2024

The platformViewRegistry getter is deprecated and will be removed in a future release. Please import it from dart:ui_web instead. deakjahn/flutter_dropzone#73

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`ui_web` library #40608

`ui_web` library #40608

eyebrowsoffire commented Mar 24, 2023

mdebbar left a comment

mdebbar Mar 24, 2023

eyebrowsoffire Mar 24, 2023

mdebbar Mar 24, 2023

mdebbar Mar 24, 2023

eyebrowsoffire Mar 24, 2023

eyebrowsoffire Mar 24, 2023

yjbanov left a comment

kevmoo Mar 27, 2023

eyebrowsoffire Mar 27, 2023

kevmoo Mar 27, 2023

kevmoo Mar 27, 2023

eyebrowsoffire Mar 27, 2023

kevmoo commented Mar 27, 2023 via email

eyebrowsoffire commented Mar 28, 2023

ui_web library #40608

ui_web library #40608

Conversation

eyebrowsoffire commented Mar 24, 2023

mdebbar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yjbanov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevmoo commented Mar 27, 2023 via email

eyebrowsoffire commented Mar 28, 2023

`ui_web` library #40608

`ui_web` library #40608