Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use an unnamed library on which to hang the TestOn annotation #40669

Closed
wants to merge 1 commit into from

Conversation

srawlins
Copy link
Contributor

This is an enforced rule, for packages with an SDK constraint at or above 2.19.

I found this issue on a recent flutter-analyze trybot run for the Dart SDK: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8785451814245563585/+/u/analyze_flutter_engine/stdout?format=raw

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 27, 2023
@srawlins
Copy link
Contributor Author

CC @yjbanov

@kevmoo kevmoo mentioned this pull request Mar 27, 2023
@ditman
Copy link
Member

ditman commented Mar 28, 2023

@srawlins I didn't see this fix forward so I reverted and relanded my change.

Thanks for the fix though!!

@ditman ditman closed this Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants