[Impeller] Adds golden image tests. #40366

gaaclarke · 2023-03-16T21:34:01Z

~~required recipe change: https://flutter-review.googlesource.com/c/recipes/+/41061~~ edit: Moved to engine_v2 so we don't need a recipe change.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2023-03-22T20:29:44Z

(golden tasks don't run unless the PR is ready for review, I'm not sure if CI will catch me pull it back out of draft)

gaaclarke · 2023-03-23T20:36:48Z

Okay, I got a successful run with the old recipe: https://logs.chromium.org/logs/flutter/led/aaclarke_google.com/5babce06c8375a7893c5b8f411ffce337d4713fc090b92c9baa22ece8f2dedbc/+/u/test:_Host_Tests_for_host_release/stdout

I'm going to continue trying to get this working on engine_v2 since the old recipe is going to be phased out.

Added golden image tests to impeller

…sions) (#123568) * c75811491 Roll Dart SDK from 17655a04d99a to a040e32db8f2 (1 revision) (flutter/engine#40612) * 274196e22 Make PathComponent POD, allow querying specific component type counts (flutter/engine#40605) * f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366) * f3b880d7a Roll Dart SDK from a040e32db8f2 to 25d7c5d88496 (1 revision) (flutter/engine#40618) * a5002f6b6 Roll Fuchsia Linux SDK from jdkyVHuAgQFiwEVQj... to 6JDOgmv1GqjN0MccU... (flutter/engine#40622) * bdee86a83 Roll Dart SDK from 25d7c5d88496 to 57061b644e84 (1 revision) (flutter/engine#40624) * 6b27c106e Roll Fuchsia Mac SDK from Nrn4D-aMBpMe5ngaF... to odB7mmGuAH51yrWgy... (flutter/engine#40625) * 1febe9dc3 Roll Skia from 497dc2e1f01f to 17bce5f4f78f (2 revisions) (flutter/engine#40629) * 3f9008208 [Impeller] More sundry fixes to the Vulkan backend. (flutter/engine#40603) * 20cf8ebb4 Roll Skia from 17bce5f4f78f to d06e59e7d041 (1 revision) (flutter/engine#40630) * 538c7eaa2 Roll Fuchsia Linux SDK from 6JDOgmv1GqjN0MccU... to smNcvjxC6Ja3FkteX... (flutter/engine#40631) * 2b5e95e6e Roll Fuchsia Mac SDK from odB7mmGuAH51yrWgy... to 34M7LHe2DUL5mebOm... (flutter/engine#40633) * 2270e07e7 Roll Skia from d06e59e7d041 to 009ed54d103d (1 revision) (flutter/engine#40644) * 6c5be6a3b Roll Fuchsia Linux SDK from smNcvjxC6Ja3FkteX... to y4h2rtyt6Mx8xHEte... (flutter/engine#40647) * eefb0be0a Roll Fuchsia Mac SDK from 34M7LHe2DUL5mebOm... to d30zLnNyJDgYNmKD4... (flutter/engine#40649) * d5e7ff24b [Impeller] Enable RendererTest::TheImpeller for Vulkan. (flutter/engine#40634) * 61b92a725 [Impeller] Keep impeller scene build working (flutter/engine#40635) * 5be21e2bd [Impeller] Fix AtlasContents crash (flutter/engine#40637) * ac769511e [Impeller] Fix accumulating translucency opacity peephole bug (flutter/engine#40639) * 1cf3bf117 [Impeller] Fix stroke cap disconnection (flutter/engine#40643) * 551f089c6 [Impeller] Remove verbose validation logs in the Vulkan pipeline cache. (flutter/engine#40651) * 567be2665 Roll Dart SDK from 57061b644e84 to c1185c030a98 (2 revisions) (flutter/engine#40654) * 3ecc5cc53 Revert Dart SDK to a040e32db8f2 (flutter/engine#40656) * 60b6a1f7b Roll Fuchsia Linux SDK from y4h2rtyt6Mx8xHEte... to v0tCO5SkPScqIBWIr... (flutter/engine#40655) * 736b4076f Roll Skia from 009ed54d103d to 4d02e783654f (1 revision) (flutter/engine#40657) * 256ae6010 Roll Skia from 4d02e783654f to 4ca827754bc1 (2 revisions) (flutter/engine#40659) * a3d5d3274 Roll Fuchsia Mac SDK from d30zLnNyJDgYNmKD4... to trm3jGwgZopG-wITx... (flutter/engine#40660) * 5f517d646 Bump actions/checkout from 3.4.0 to 3.5.0 (flutter/engine#40662) * 708bf70ab Remove timezone from flutter (flutter/engine#40588) * d21f657e6 Post 3.0 lint sync (flutter/engine#40394) * d58d7d999 [Impeller] Document EntityPass, make positioning less confusing (flutter/engine#40636) * 6c3f5fe15 Roll Fuchsia Linux SDK from v0tCO5SkPScqIBWIr... to jlj9dbwYl_4cILVwQ... (flutter/engine#40665) * f7d257198 [web] Accepts assetBase through JS config. (flutter/engine#40615) * 6cc2f9bbf Revert "[web] Accepts assetBase through JS config. (#40615)" (flutter/engine#40670) * 4eea74c9a [Impeller] initialize text alpha to 1.0 (flutter/engine#40667) * f7eea0ea2 Roll Skia from 4ca827754bc1 to c55605969a59 (5 revisions) (flutter/engine#40668) * 50f837497 [web] Add `js_types` sources to build. (flutter/engine#40597) * d468552bc Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (flutter/engine#40582) * 36f8473bc Simplify SkFontMgr classes for sk_sp (flutter/engine#40627) * cc060144e [Impeller] Fix Impeller Metal wide gamut (flutter/engine#40671) * 4bc9341d0 Revert "[web] Add `js_types` sources to build. (#40597)" (flutter/engine#40685) * 9c0d1dbf0 Revert "Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (#40582)" (flutter/engine#40686) * 8cb080365 Revert "Post 3.0 lint sync (#40394)" (flutter/engine#40687)

gaaclarke force-pushed the impeller-golden-images branch 4 times, most recently from 24a3975 to 2672f20 Compare March 16, 2023 22:58

gaaclarke mentioned this pull request Mar 17, 2023

[Impeller] Fixed the conical gradient. #40371

Merged

8 tasks

chinmaygarde changed the title ~~Added golden image tests to impeller~~ [Impeller] Added golden image tests. Mar 17, 2023

chinmaygarde assigned gaaclarke Mar 17, 2023

chinmaygarde added the e: impeller label Mar 17, 2023

gaaclarke force-pushed the impeller-golden-images branch 8 times, most recently from 736f494 to 90677c8 Compare March 20, 2023 22:52

gaaclarke changed the title ~~[Impeller] Added golden image tests.~~ [Impeller] Adds golden image tests. Mar 20, 2023

gaaclarke marked this pull request as ready for review March 22, 2023 20:17

gaaclarke marked this pull request as draft March 22, 2023 20:25

This comment was marked as outdated.

Sign in to view

gaaclarke marked this pull request as ready for review March 22, 2023 20:29

gaaclarke force-pushed the impeller-golden-images branch from d61c2da to 39a49b9 Compare March 22, 2023 22:59

gaaclarke force-pushed the impeller-golden-images branch 2 times, most recently from 1776333 to 6925863 Compare March 23, 2023 21:09

gaaclarke added 4 commits March 24, 2023 09:27

Added golden image tests to impeller

d6d5695

started writing a digest

b17819e

added docstrings

345d019

added harvester

93725ba

engine-flutter-autoroll mentioned this pull request Mar 26, 2023

Roll Flutter Engine from 685fbc6f4d9d to 6c5be6a3bc79 (14 revisions) flutter/flutter#123498

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

a7ed11a

engine-flutter-autoroll mentioned this pull request Mar 26, 2023

Roll Flutter Engine from 685fbc6f4d9d to eefb0be0a016 (15 revisions) flutter/flutter#123502

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

5b303be

engine-flutter-autoroll mentioned this pull request Mar 26, 2023

Roll Flutter Engine from 685fbc6f4d9d to d5e7ff24bfb7 (16 revisions) flutter/flutter#123503

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

0618df6

engine-flutter-autoroll mentioned this pull request Mar 26, 2023

Roll Flutter Engine from 685fbc6f4d9d to 5be21e2bd7e8 (18 revisions) flutter/flutter#123504

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

d3c6499

engine-flutter-autoroll mentioned this pull request Mar 26, 2023

Roll Flutter Engine from 685fbc6f4d9d to ac769511e6ca (19 revisions) flutter/flutter#123505

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

02f8a77

engine-flutter-autoroll mentioned this pull request Mar 26, 2023

Roll Flutter Engine from 685fbc6f4d9d to 1cf3bf117e15 (20 revisions) flutter/flutter#123506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

c333608

engine-flutter-autoroll mentioned this pull request Mar 26, 2023

Roll Flutter Engine from 685fbc6f4d9d to 1cf3bf117e15 (20 revisions) flutter/flutter#123509

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

ca18f4a

engine-flutter-autoroll mentioned this pull request Mar 26, 2023

Roll Flutter Engine from 685fbc6f4d9d to 551f089c6cc9 (21 revisions) flutter/flutter#123510

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

e523852

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Roll Flutter Engine from 685fbc6f4d9d to 551f089c6cc9 (21 revisions) flutter/flutter#123513

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

c64f657

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Roll Flutter Engine from 685fbc6f4d9d to 567be2665cb7 (22 revisions) flutter/flutter#123514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

6b676d2

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Roll Flutter Engine from 685fbc6f4d9d to 3ecc5cc53bd0 (23 revisions) flutter/flutter#123521

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

a53238d

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Roll Flutter Engine from 685fbc6f4d9d to 6cc2f9bbfa77 (34 revisions) flutter/flutter#123558

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

ae664b0

eyebrowsoffire pushed a commit to eyebrowsoffire/engine that referenced this pull request Mar 27, 2023

[Impeller] Adds golden image tests. (flutter#40366)

b8e6c54

Added golden image tests to impeller

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Roll Flutter Engine from 685fbc6f4d9d to cc060144e81b (40 revisions) flutter/flutter#123562

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

483fe70

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Manual roll Flutter Engine from 685fbc6f4d9d to 8cb080365fb1 (43 revisions) flutter/flutter#123568

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366)

5c1d387

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Adds golden image tests. #40366

[Impeller] Adds golden image tests. #40366

Uh oh!

gaaclarke commented Mar 16, 2023 •

edited

Loading

Uh oh!

This comment was marked as outdated.

gaaclarke commented Mar 22, 2023

Uh oh!

gaaclarke commented Mar 23, 2023

Uh oh!

Uh oh!

[Impeller] Adds golden image tests. #40366

[Impeller] Adds golden image tests. #40366

Uh oh!

Conversation

gaaclarke commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

This comment was marked as outdated.

gaaclarke commented Mar 22, 2023

Uh oh!

gaaclarke commented Mar 23, 2023

Uh oh!

Uh oh!

gaaclarke commented Mar 16, 2023 •

edited

Loading