Post 3.0 lint sync #40394

goderbauer · 2023-03-17T18:49:54Z

goderbauer · 2023-03-17T22:50:55Z

Blocked until the pre-built Dart SDK has been bumped past 3.0.0-325.0.dev.

goderbauer · 2023-03-24T16:20:31Z

Should be unblocked by Dart v3.0.0-366.0.dev rolling into the engine.

ditman

- break;

RSLGTM, if Dan and CI like it too.

The web_ui bits look good to me. Most of them are removing break; from switches. I've left a couple of questions.

Heads up @eyebrowsoffire, potentially big conflicts incoming with your test reorg PR?

ditman · 2023-03-25T00:26:19Z

lib/web_ui/lib/src/engine/text/word_breaker.dart

@@ -5,11 +5,11 @@
 import '../util.dart';
 import 'word_break_properties.dart';

-class _FindBreakDirection {
-  const _FindBreakDirection({required this.step});
+enum _FindBreakDirection {


Was this automatically detected by a lint? wow!

ditman · 2023-03-25T00:27:26Z

lib/web_ui/test/canvaskit/semantics_test.dart

@@ -3,6 +3,7 @@
 // found in the LICENSE file.

 @TestOn('chrome || safari || firefox')
+library;


Why are these empty library; needed? Is it because of the @TestOn?

Yeah, previously, the TestOn was technically annotating the next import statement.

dnfield

LGTM

dnfield · 2023-03-27T16:14:18Z

analysis_options.yaml

@@ -168,10 +168,10 @@ linter:
    - provide_deprecation_message
    - public_member_api_docs # DIFFERENT FROM FLUTTER/FLUTTER
    - recursive_getters
-    # - require_trailing_commas # blocked on https://github.com/dart-lang/sdk/issues/47441
+    # - require_trailing_commas # would be nice, but requires a lot of manual work: 10,000+ code locations would need to be reformatted by hand after bulk fix is applied


What does dart format --line-length=120 look like?

Should not be handled in this PR but might work well enough.

Maybe splitting the web and VM implementations would help too, because I think at some point web used dartfmt.

It's probably much more realistic to enable this for the engine than it is for the framework, it will need some additional investigation, though.

fix comment

Post 3.0 lint sync

This reverts commit d21f657.

This reverts commit 8cb0803.

…sions) (#123568) * c75811491 Roll Dart SDK from 17655a04d99a to a040e32db8f2 (1 revision) (flutter/engine#40612) * 274196e22 Make PathComponent POD, allow querying specific component type counts (flutter/engine#40605) * f59822430 [Impeller] Adds golden image tests. (flutter/engine#40366) * f3b880d7a Roll Dart SDK from a040e32db8f2 to 25d7c5d88496 (1 revision) (flutter/engine#40618) * a5002f6b6 Roll Fuchsia Linux SDK from jdkyVHuAgQFiwEVQj... to 6JDOgmv1GqjN0MccU... (flutter/engine#40622) * bdee86a83 Roll Dart SDK from 25d7c5d88496 to 57061b644e84 (1 revision) (flutter/engine#40624) * 6b27c106e Roll Fuchsia Mac SDK from Nrn4D-aMBpMe5ngaF... to odB7mmGuAH51yrWgy... (flutter/engine#40625) * 1febe9dc3 Roll Skia from 497dc2e1f01f to 17bce5f4f78f (2 revisions) (flutter/engine#40629) * 3f9008208 [Impeller] More sundry fixes to the Vulkan backend. (flutter/engine#40603) * 20cf8ebb4 Roll Skia from 17bce5f4f78f to d06e59e7d041 (1 revision) (flutter/engine#40630) * 538c7eaa2 Roll Fuchsia Linux SDK from 6JDOgmv1GqjN0MccU... to smNcvjxC6Ja3FkteX... (flutter/engine#40631) * 2b5e95e6e Roll Fuchsia Mac SDK from odB7mmGuAH51yrWgy... to 34M7LHe2DUL5mebOm... (flutter/engine#40633) * 2270e07e7 Roll Skia from d06e59e7d041 to 009ed54d103d (1 revision) (flutter/engine#40644) * 6c5be6a3b Roll Fuchsia Linux SDK from smNcvjxC6Ja3FkteX... to y4h2rtyt6Mx8xHEte... (flutter/engine#40647) * eefb0be0a Roll Fuchsia Mac SDK from 34M7LHe2DUL5mebOm... to d30zLnNyJDgYNmKD4... (flutter/engine#40649) * d5e7ff24b [Impeller] Enable RendererTest::TheImpeller for Vulkan. (flutter/engine#40634) * 61b92a725 [Impeller] Keep impeller scene build working (flutter/engine#40635) * 5be21e2bd [Impeller] Fix AtlasContents crash (flutter/engine#40637) * ac769511e [Impeller] Fix accumulating translucency opacity peephole bug (flutter/engine#40639) * 1cf3bf117 [Impeller] Fix stroke cap disconnection (flutter/engine#40643) * 551f089c6 [Impeller] Remove verbose validation logs in the Vulkan pipeline cache. (flutter/engine#40651) * 567be2665 Roll Dart SDK from 57061b644e84 to c1185c030a98 (2 revisions) (flutter/engine#40654) * 3ecc5cc53 Revert Dart SDK to a040e32db8f2 (flutter/engine#40656) * 60b6a1f7b Roll Fuchsia Linux SDK from y4h2rtyt6Mx8xHEte... to v0tCO5SkPScqIBWIr... (flutter/engine#40655) * 736b4076f Roll Skia from 009ed54d103d to 4d02e783654f (1 revision) (flutter/engine#40657) * 256ae6010 Roll Skia from 4d02e783654f to 4ca827754bc1 (2 revisions) (flutter/engine#40659) * a3d5d3274 Roll Fuchsia Mac SDK from d30zLnNyJDgYNmKD4... to trm3jGwgZopG-wITx... (flutter/engine#40660) * 5f517d646 Bump actions/checkout from 3.4.0 to 3.5.0 (flutter/engine#40662) * 708bf70ab Remove timezone from flutter (flutter/engine#40588) * d21f657e6 Post 3.0 lint sync (flutter/engine#40394) * d58d7d999 [Impeller] Document EntityPass, make positioning less confusing (flutter/engine#40636) * 6c3f5fe15 Roll Fuchsia Linux SDK from v0tCO5SkPScqIBWIr... to jlj9dbwYl_4cILVwQ... (flutter/engine#40665) * f7d257198 [web] Accepts assetBase through JS config. (flutter/engine#40615) * 6cc2f9bbf Revert "[web] Accepts assetBase through JS config. (#40615)" (flutter/engine#40670) * 4eea74c9a [Impeller] initialize text alpha to 1.0 (flutter/engine#40667) * f7eea0ea2 Roll Skia from 4ca827754bc1 to c55605969a59 (5 revisions) (flutter/engine#40668) * 50f837497 [web] Add `js_types` sources to build. (flutter/engine#40597) * d468552bc Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (flutter/engine#40582) * 36f8473bc Simplify SkFontMgr classes for sk_sp (flutter/engine#40627) * cc060144e [Impeller] Fix Impeller Metal wide gamut (flutter/engine#40671) * 4bc9341d0 Revert "[web] Add `js_types` sources to build. (#40597)" (flutter/engine#40685) * 9c0d1dbf0 Revert "Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (#40582)" (flutter/engine#40686) * 8cb080365 Revert "Post 3.0 lint sync (#40394)" (flutter/engine#40687)

This reverts commit 8cb0803.

Reland "Post 3.0 lint sync (#40394)"

goderbauer force-pushed the lintSync branch 3 times, most recently from dcd8d95 to 4d8514c Compare March 17, 2023 21:11

flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 17, 2023

goderbauer force-pushed the lintSync branch 2 times, most recently from 416a4c0 to 81336b0 Compare March 17, 2023 22:33

goderbauer force-pushed the lintSync branch from 81336b0 to 09df472 Compare March 20, 2023 18:33

goderbauer mentioned this pull request Mar 21, 2023

☂️ Prepare for Dart 3 flutter/flutter#118837

Closed

23 tasks

goderbauer force-pushed the lintSync branch from ba77e3c to 70ff8bf Compare March 22, 2023 21:15

goderbauer mentioned this pull request Mar 22, 2023

Update checked-in Dart SDK dart-lang/sdk#51824

Closed

goderbauer force-pushed the lintSync branch from 70ff8bf to a6b3243 Compare March 24, 2023 18:26

goderbauer marked this pull request as ready for review March 24, 2023 18:37

goderbauer requested review from ditman and dnfield March 24, 2023 19:51

ditman reviewed Mar 25, 2023

View reviewed changes

goderbauer requested a review from eyebrowsoffire March 25, 2023 20:34

dnfield approved these changes Mar 27, 2023

View reviewed changes

goderbauer added 11 commits March 27, 2023 09:22

sync lints post 3.0

f097ef7

ui

c91fff8

web_ui

4d91780

fix comment

ci

e86db15

flutter_frontend_server

cdc6188

tools

8d51a0c

testing

363196b

web_sdk

843acf8

enable prefer_mixin

80c5bc7

Update analysis_options.yaml

8da7b08

Update tool_signature

977e727

Update tool_signature

81d878f

goderbauer force-pushed the lintSync branch from 2ee9998 to 81d878f Compare March 27, 2023 16:22

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023

auto-submit bot merged commit d21f657 into flutter:main Mar 27, 2023

goderbauer deleted the lintSync branch March 27, 2023 17:19

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Roll Flutter Engine from 685fbc6f4d9d to 6cc2f9bbfa77 (34 revisions) flutter/flutter#123558

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

d21f657e6 Post 3.0 lint sync (flutter/engine#40394)

b8bd4ed

eyebrowsoffire pushed a commit to eyebrowsoffire/engine that referenced this pull request Mar 27, 2023

Post 3.0 lint sync (flutter#40394)

9b4b0b4

Post 3.0 lint sync

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Roll Flutter Engine from 685fbc6f4d9d to cc060144e81b (40 revisions) flutter/flutter#123562

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

d21f657e6 Post 3.0 lint sync (flutter/engine#40394)

d482851

bdero added a commit that referenced this pull request Mar 27, 2023

Revert "Post 3.0 lint sync (#40394)"

71318e5

This reverts commit d21f657.

bdero mentioned this pull request Mar 27, 2023

Revert "Post 3.0 lint sync" #40687

Merged

bdero added a commit that referenced this pull request Mar 27, 2023

Revert "Post 3.0 lint sync (#40394)" (#40687)

8cb0803

This reverts commit d21f657.

eyebrowsoffire mentioned this pull request Mar 27, 2023

At least some web engine tests should run on the post-sdk_rewritered web SDK flutter/flutter#123567

Open

goderbauer added a commit to goderbauer/engine that referenced this pull request Mar 27, 2023

Reland "Post 3.0 lint sync (flutter#40394)"

34714ff

This reverts commit 8cb0803.

engine-flutter-autoroll mentioned this pull request Mar 27, 2023

Manual roll Flutter Engine from 685fbc6f4d9d to 8cb080365fb1 (43 revisions) flutter/flutter#123568

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023

d21f657e6 Post 3.0 lint sync (flutter/engine#40394)

c2e1037

This was referenced Mar 28, 2023

Revert "Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule" #40686

Merged

Revert "[web] Add js_types sources to build." #40685

Merged

goderbauer added a commit to goderbauer/engine that referenced this pull request Mar 28, 2023

Reland "Post 3.0 lint sync (flutter#40394)"

987548f

This reverts commit 8cb0803.

auto-submit bot pushed a commit that referenced this pull request Mar 28, 2023

Reland "Post 3.0 lint sync (#40394)" (#40688)

3d730c5

Reland "Post 3.0 lint sync (#40394)"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Post 3.0 lint sync #40394

Post 3.0 lint sync #40394

goderbauer commented Mar 17, 2023 •

edited

Loading

goderbauer commented Mar 17, 2023

goderbauer commented Mar 24, 2023

ditman left a comment

ditman Mar 25, 2023

goderbauer Mar 25, 2023

ditman Mar 25, 2023

goderbauer Mar 25, 2023

dnfield left a comment

dnfield Mar 27, 2023

dnfield Mar 27, 2023

goderbauer Mar 27, 2023

Post 3.0 lint sync #40394

Post 3.0 lint sync #40394

Conversation

goderbauer commented Mar 17, 2023 • edited Loading

goderbauer commented Mar 17, 2023

goderbauer commented Mar 24, 2023

ditman left a comment

Choose a reason for hiding this comment

ditman Mar 25, 2023

Choose a reason for hiding this comment

goderbauer Mar 25, 2023

Choose a reason for hiding this comment

ditman Mar 25, 2023

Choose a reason for hiding this comment

goderbauer Mar 25, 2023

Choose a reason for hiding this comment

dnfield left a comment

Choose a reason for hiding this comment

dnfield Mar 27, 2023

Choose a reason for hiding this comment

dnfield Mar 27, 2023

Choose a reason for hiding this comment

goderbauer Mar 27, 2023

Choose a reason for hiding this comment

goderbauer commented Mar 17, 2023 •

edited

Loading