Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "[web] Better way to detect CanvasKit variant (#40154)" #40347

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 16, 2023

First landed here: #40154
Then reverted here: #40329

@mdebbar mdebbar requested a review from gaaclarke March 16, 2023 14:37
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 16, 2023
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reland looks good. I read through the chat logs and I think the dart change you needed is available now? Would a rebase assert that in ci?

@mdebbar
Copy link
Contributor Author

mdebbar commented Mar 16, 2023

@gaaclarke the change I need landed 11 hours ago in #40341 and hasn't been reverted so far (🤞). The green checks on this PR are already running on top of that Dart roll, so I think we are good to go.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants