-
Notifications
You must be signed in to change notification settings - Fork 6k
[web] Better way to detect CanvasKit variant #40154
Conversation
ca06cbe
to
995ef10
Compare
auto label is removed for flutter/engine, pr: 40154, due to - The status or check suite Linux Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
const bool browserSupportsCanvaskitChromium = false; | ||
// TODO(mdebbar): Uncomment this to enable real detection of browser support. | ||
// final bool browserSupportsCanvaskitChromium = domIntl.v8BreakIterator != null; | ||
final bool browserSupportsCanvaskitChromium = domIntl.v8BreakIterator != null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If canvaskit_chromium
also removes the wasm image codecs, then this should also add && browserSupportsImageDecoder
. Although in practice, I'm not aware of any Chromium-based browser not supporting image decoders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto label is removed for flutter/engine, pr: 40154, due to - The status or check suite Linux Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
There's a timeout failure happening in wasm mode. This line is causing a hard wasm failure: engine/lib/web_ui/lib/src/engine/dom.dart Line 2164 in 161f759
because the js_util.getProperty(...) patch in dart2wasm has the wrong signature (it shoud be Function(Object, Object) instead of Function(Object, String) ).
This is being fixed in https://dart-review.googlesource.com/c/sdk/+/288161. (Thanks @joshualitt!). Once that Dart CL lands and rolls into the engine, I'll rebase and try again. Thanks @eyebrowsoffire for looking into this with me! |
This reverts commit e447f20.
Partial revert of #40027
For more info, see: https://skia-review.googlesource.com/c/skia/+/653416
The above CL introduces a new CanvasKit API to tell us whether it needs client ICU data or not. This allows us to do a more robust detection of the CanvasKit variant we are using.
BEFORE MERGING:Make a new CanvasKit release that contains the required changes, and roll to that version.Fixes flutter/flutter#121905